D22662: Add common GLSL file extensions (.vs, .gs, .fs)

cullmann closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22662 To: smokris, #framework_syntax_highlighting, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, sars,

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

smokris added a comment. Sounds good, thanks. I just emailed you at your KDE address. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22662 To: smokris, #framework_syntax_highlighting, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel,

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

cullmann added a comment. If you pass me name + email, will push it. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22662 To: smokris, #framework_syntax_highlighting, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson,

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Sorry, then I did misread that in the diff, I thought QTest::newRow("fs") << QStringLiteral("test.fs") << QStringLiteral("FSharp"); enforces that FSharp is used, not the other way

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

smokris requested review of this revision. smokris added a comment. In D22662#511424 , @cullmann wrote: > I am not sure we want to override F# for .fs. > Either we should not add that or we shall lower the priority of this highlighting to

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I am not sure we want to override F# for .fs. Either we should not add that or we shall lower the priority of this highlighting to loose against F#. REPOSITORY R216

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

smokris added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22662 To: smokris, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns,

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

smokris created this revision. smokris added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. smokris requested review of this revision. REVISION SUMMARY These 2-letter extensions are used by, for example: -