D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Christoph Cullmann]

cullmann closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Steve Mokris]

smokris added a comment.


  Sounds good, thanks.  I just emailed you at your KDE address.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Christoph Cullmann]

cullmann added a comment.


  If you pass me name + email, will push it.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Sorry, then I did misread that in the diff, I thought QTest::newRow("fs") << 
QStringLiteral("test.fs") << QStringLiteral("FSharp"); enforces that FSharp is 
used, not the other way around ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Steve Mokris]

smokris requested review of this revision.
smokris added a comment.


  In D22662#511424 , @cullmann wrote:
  
  > I am not sure we want to override F# for .fs.
  >  Either we should not add that or we shall lower the priority of this 
highlighting to loose against F#.
  
  
  The test I added verifies that F# is still being chosen for the `.fs` 
extension (and that GLSL, added by this change, loses to F#'s higher priority).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I am not sure we want to override F# for .fs.
  Either we should not add that or we shall lower the priority of this 
highlighting to loose against F#.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Steve Mokris]

smokris added a reviewer: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Steve Mokris]

smokris created this revision.
smokris added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
smokris requested review of this revision.

REVISION SUMMARY
  These 2-letter extensions are used by, for example:
  
  - https://www.interactiveshaderformat.com/about
  - https://github.com/euler0/sublime-glsl
  - https://github.com/polym0rph/GLSL.tmbundle
  - http://plugins.netbeans.org/plugin/46515/glsl-syntax-highlighter

TEST PLAN
  This commit also adds a test to ensure that .fs still defaults to FSharp.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

AFFECTED FILES
  syntax/glsl.xml
  syntaxrepository_test.cpp

To: smokris
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann