D22764: Stabilize test KFileWidgetTest::testDropFile

dfaure added inline comments. INLINE COMMENTS > meven wrote in kfilewidgettest.cpp:481 > Let me know if I should relay you. I thought I did that in commit eb18397fe525d2e4bd9 ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22764 To: meven, dfaure, #frameworks Cc:

D22764: Stabilize test KFileWidgetTest::testDropFile

meven added inline comments. INLINE COMMENTS > dfaure wrote in kfilewidgettest.cpp:481 > For the record, this is broken, it should have been `completed(QUrl)`. > Specifying argument names is incorrect in SIGNAL() and SLOT() macros. > > It makes the wait() below fail every time, but after 5s,

D22764: Stabilize test KFileWidgetTest::testDropFile

dfaure added inline comments. INLINE COMMENTS > kfilewidgettest.cpp:481 > +KDirLister *dirLister = fileWidget.dirOperator()->dirLister(); > +QSignalSpy spy(dirLister, SIGNAL(completed(const QUrl &_url))); > + For the record, this is broken, it should have been `completed(QUrl)`.

D22764: Stabilize test KFileWidgetTest::testDropFile

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bbe3e6edfd63: Stabilize test KFileWidgetTest::testDropFile (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22764?vs=62610=62615 REVISION DETAIL

D22764: Stabilize test KFileWidgetTest::testDropFile

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Excellent, thanks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D22764 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n,

D22764: Stabilize test KFileWidgetTest::testDropFile

meven added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22764 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22764: Stabilize test KFileWidgetTest::testDropFile

meven created this revision. meven added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The test introduced in D20838 was not completely