D22764: Stabilize test KFileWidgetTest::testDropFile

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> meven wrote in kfilewidgettest.cpp:481
> Let me know if I should relay you.

I thought I did that in commit eb18397fe525d2e4bd9 ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22764

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22764: Stabilize test KFileWidgetTest::testDropFile

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> dfaure wrote in kfilewidgettest.cpp:481
> For the record, this is broken, it should have been `completed(QUrl)`. 
> Specifying argument names is incorrect in SIGNAL() and SLOT() macros.
> 
> It makes the wait() below fail every time, but after 5s, so the 100ms became 
> 5s :-)
> 
> I'm working on fixing this.

Let me know if I should relay you.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22764

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22764: Stabilize test KFileWidgetTest::testDropFile

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kfilewidgettest.cpp:481
> +KDirLister *dirLister = fileWidget.dirOperator()->dirLister();
> +QSignalSpy spy(dirLister, SIGNAL(completed(const QUrl &_url)));
> +

For the record, this is broken, it should have been `completed(QUrl)`. 
Specifying argument names is incorrect in SIGNAL() and SLOT() macros.

It makes the wait() below fail every time, but after 5s, so the 100ms became 5s 
:-)

I'm working on fixing this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22764

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22764: Stabilize test KFileWidgetTest::testDropFile

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bbe3e6edfd63: Stabilize test 
KFileWidgetTest::testDropFile (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22764?vs=62610=62615

REVISION DETAIL
  https://phabricator.kde.org/D22764

AFFECTED FILES
  autotests/kfilewidgettest.cpp

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22764: Stabilize test KFileWidgetTest::testDropFile

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Excellent, thanks.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22764

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22764: Stabilize test KFileWidgetTest::testDropFile

[Méven Car]

meven added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22764

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22764: Stabilize test KFileWidgetTest::testDropFile

[Méven Car]

meven created this revision.
meven added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  The test introduced in D20838  was not 
completely stable.
  It causes failures on CI :
  
  
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/139/testReport/junit/projectroot/autotests/kiofilewidgets_kfilewidgettest/
  
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.13/job/kio/job/kf5-qt5%20SUSEQt5.13/7/testReport/projectroot/autotests/kiofilewidgets_kfilewidgettest/
  
  This patch replaces a wait by an appropriate QSignalSpy.

TEST PLAN
  LANG ctest -R kiofilewidgets

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22764

AFFECTED FILES
  autotests/kfilewidgettest.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns