D22805: set autorcc and autouic by default

fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R240

D22805: set autorcc and autouic by default

sitter abandoned this revision. sitter added a comment. D23262 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter, apol, nicolasfella Cc: cullmann, nicolasfella, cgiboudeaux, vkrause, kossebau, apol,

D22805: set autorcc and autouic by default

cullmann added a comment. Yep, KTextEditor is broken for me, too. AutoUic error - "/local/ssd/cullmann/kde/src/ktexteditor/src/completion/katecompletionconfig.cpp" Could not find "completionconfigwidget.ui" in

D22805: set autorcc and autouic by default

nicolasfella requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter, apol, nicolasfella Cc: nicolasfella, cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel,

D22805: set autorcc and autouic by default

nicolasfella reopened this revision. nicolasfella added a comment. This revision is now accepted and ready to land. This seems to cause the build of sonnet to fail: https://invent.kde.org/snippets/394 Another user has reported that ktexteditor and knewstuff fail too REPOSITORY R240

D22805: set autorcc and autouic by default

This revision was automatically updated to reflect the committed changes. Closed by commit R240:60ca1a27e539: set autorcc and autouic by default (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=64033=64037 REVISION

D22805: set autorcc and autouic by default

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter, apol Cc: cgiboudeaux, vkrause, kossebau, apol,

D22805: set autorcc and autouic by default

sitter updated this revision to Diff 64033. sitter added a comment. typo-- REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=64032=64033 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22805 AFFECTED FILES

D22805: set autorcc and autouic by default

sitter updated this revision to Diff 64032. sitter added a comment. bump version again REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=62838=64032 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22805 AFFECTED FILES

D22805: set autorcc and autouic by default

kossebau added a comment. Patch as is fine with me. But no expert on both flags itself, no idea if there could be sideeffects of having those two now injected as ON to all projects. Possibly best to do global rebuilds of all projects on CI once this lands. REPOSITORY R240 Extra CMake

D22805: set autorcc and autouic by default

vkrause added a comment. I'm happy with this, +2 from my side. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham,

D22805: set autorcc and autouic by default

cgiboudeaux added a comment. @kossebau @vkrause @apol something else to change? INLINE COMMENTS > KDECMakeSettings.cmake:82 > +# - CMAKE_AUTORCC and CMAKE_AUTOUIC enabled by default when supported by > cmake > +# (>= 3.0) since 5.61.0 > # 5.62 now REPOSITORY R240 Extra CMake Modules

D22805: set autorcc and autouic by default

sitter retitled this revision from "set autorcc by default" to "set autorcc and autouic by default". sitter edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: vkrause, kossebau, apol,