This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ff06ba217e40: fix additionalDeliminator attribute
(authored by jpoelen, committed by cullmann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D23134?vs=63771=63835#toc
REPOSITORY
R216
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Thanks for the test.
With git diff -w the patch looks fine.
REPOSITORY
R216 Syntax Highlighting
BRANCH
fix_wordDelimiters (branched from master)
REVISION DETAIL
jpoelen updated this revision to Diff 63771.
jpoelen added a comment.
- add unit test
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23134?vs=63683=63771
BRANCH
fix_wordDelimiters (branched from master)
REVISION DETAIL
dhaumann added a comment.
Could you add a unit test for this?
- add the dummy xml similar to the one in the bug report. This can be done by
using the additional search folder in the Repository.
- add a test highlighting like done with the others
The so only when the unit tests
jpoelen added a comment.
I don't understand why there's so much difference in what's displayed :/
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D23134
To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel,
jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.
REVISION SUMMARY
The initialization of the `Rule::m_wordDelimiter` cache was done before the
