This revision was automatically updated to reflect the committed changes.
Closed by commit R285:e64b8314e201: Avoid enabling kcrash if its only
included via a plugin (authored by davidedmundson).
REPOSITORY
R285 KCrash
CHANGES SINCE LAST UPDATE
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
the logic is awesome, the checking with the static is not super pretty but
saves significantly useless checks
REPOSITORY
R285 KCrash
BRANCH
master
REVISION DETAIL
davidedmundson added a comment.
Alternatively we could just kill the Q_COREAPP_STARTUP_FUNCTION as most apps
already explicitly call KCrash::initialize() to get round distros compiling
with link-as-needed?
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D23171
To:
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
If a Qt app happens to load our plasma-integration plugin it shouldn't
change how bug reporting works.