D23196: have the app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 64114. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=64113&id=64114 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES src/notifybysnore.cpp To: brute4s99,

D23196: have the app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 64113. brute4s99 added a comment. rebased REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=63984&id=64113 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES

D23196: have the app icon as fallback icon in Snore

brute4s99 added a comment. landing it! F7262311: shufflefurtherparrot.gif REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman, broulik,

D23196: have the app icon as fallback icon in Snore

brute4s99 added a comment. may I land this now? 👀 REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 63984. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=63981&id=63984 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES src/notifybysnore.cpp To: brute4s99,

D23196: have the app icon as fallback icon in Snore

brute4s99 marked 2 inline comments as done. REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 63981. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=63888&id=63981 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES src/CMakeLists.txt src/notifybysnore

D23196: have the app icon as fallback icon in Snore

sredman accepted this revision. sredman added a comment. This revision is now accepted and ready to land. Since KNotifications on Windows is so far only used by you anyway, I say it's fine to merge. @broulik, any objections? INLINE COMMENTS > notifybysnore.cpp:157 > +notification->pi

D23196: have the app icon as fallback icon in Snore

brute4s99 added a reviewer: broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 63888. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=63847&id=63888 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES

D23196: have the app icon as fallback icon in Snore

brute4s99 marked 3 inline comments as done. brute4s99 added inline comments. INLINE COMMENTS > broulik wrote in notifybysnore.cpp:163 > The explicit call to `actualSize` shouldn't be neccessary just to be sure :) but if there's a check implemented already somewhere within QIcon, I'd happily re

D23196: have the app icon as fallback icon in Snore

broulik added inline comments. INLINE COMMENTS > notifybysnore.cpp:159 > +} else { > +Qstring iconPath = QString(m_iconDir.path() + QLatin1Char('/') > ++ QString::number(notification->id()) + > QStringLiteral(".png")); Did you even compile this? Also, thi

D23196: have the app icon as fallback icon in Snore

brute4s99 created this revision. brute4s99 added a reviewer: Frameworks. brute4s99 added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY by this patch, apps with a set WindowIcon will have that icon as fallback