D23372: Add operator |= for Query Terms

meven abandoned this revision. meven added a comment. Abandoned in favor of D23399 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23372 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23372: Add operator |= for Query Terms

ivan added a comment. You can also use `set*/add*` member functions for this so that David doesn't complain. As I said, pipes are mainly there for chaining - easy query creation API to simplify the alternative of set set set set set. But if you set a single field, I'd say `set*/add*` is a

D23372: Add operator |= for Query Terms

meven added a comment. In D23372#517378 , @ivan wrote: > This is something I did have initally in kastats, it was killed because while this is tempting > > query |= Type(types); > > > it ruins the idea of the chaning API because it

D23372: Add operator |= for Query Terms

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. This is something I did have initally in kastats, it was killed because while this is tempting query |= Type(types); it ruins the idea of the chaning API because it can

D23372: Add operator |= for Query Terms

meven created this revision. meven added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY With it, we can now write : query |= Type(types); instead of : query = query |