D23464: Add breeze icons for ROOT cern files

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:018b67eff94c: Add breeze icons for ROOT cern files 
(authored by Marc Henning marc.henni...@rwth-aachen.de, committed by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23464?vs=65307=65310

REVISION DETAIL
  https://phabricator.kde.org/D23464

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-root.svg
  icons-dark/mimetypes/22/application-x-root.svg
  icons-dark/mimetypes/32/application-x-root.svg
  icons-dark/mimetypes/64/application-x-root.svg
  icons/mimetypes/16/application-x-root.svg
  icons/mimetypes/22/application-x-root.svg
  icons/mimetypes/32/application-x-root.svg
  icons/mimetypes/64/application-x-root.svg

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde added a comment.


  In D23464#524994 , @ndavis wrote:
  
  > Looks like you've got everything
  
  
  Thank you all for mentoring me! :)

REPOSITORY
  R266 Breeze Icons

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Noah Davis]

ndavis added a comment.


  Looks like you've got everything

REPOSITORY
  R266 Breeze Icons

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde updated this revision to Diff 65307.
alexde added a comment.


  16px: add 2px margins to top and bottom
  22px: add 3px margins to top and bottom
  32px: use existing and approved 32px icon as template instead of shrinking 
the 64px version

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23464?vs=65264=65307

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-root.svg
  icons-dark/mimetypes/22/application-x-root.svg
  icons-dark/mimetypes/32/application-x-root.svg
  icons-dark/mimetypes/64/application-x-root.svg
  icons/mimetypes/16/application-x-root.svg
  icons/mimetypes/22/application-x-root.svg
  icons/mimetypes/32/application-x-root.svg
  icons/mimetypes/64/application-x-root.svg

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  You're getting there.
  
  - 16px: needs 2px margins on the top and bottom
  - 22px: needs 3px margins on the top and bottom
  - 32px: needs to be lined up with the pixel grid and needs 2px margins on the 
top and bottom. You'd really be better off basing the background shape on 
another 32px icon and then applying the colors you want to use rather than 
trying to use a shrunken version of the the 64px background.
  
  In case you didn't see it before, there is an HIG and we recently improved 
the structure of the icon design section. 
https://hig.kde.org/style/icons/mimetype.html

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde updated this revision to Diff 65264.
alexde edited the test plan for this revision.
alexde added a comment.


  Remove all circles and only use root symbol.
  This makes the root symbol less faint and the icons fit better to Breeze 
overall.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23464?vs=64946=65264

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-root.svg
  icons-dark/mimetypes/22/application-x-root.svg
  icons-dark/mimetypes/32/application-x-root.svg
  icons-dark/mimetypes/64/application-x-root.svg
  icons/mimetypes/16/application-x-root.svg
  icons/mimetypes/22/application-x-root.svg
  icons/mimetypes/32/application-x-root.svg
  icons/mimetypes/64/application-x-root.svg

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Nathaniel Graham]

ngraham added a comment.


  If the 16px and 22px versions include the ring, then it needs to be in the 
larger versions as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Noah Davis]

ndavis added a comment.


  In D23464#522459 , @alexde wrote:
  
  > In D23464#522270 , 
@trickyricky26 wrote:
  >
  > > As @noahdvs mentioned above, the white background should be removed and 
the entire symbol should be made up of one filled path with no outline (!). 
This is important to keep the icon looking as intended with the Qt SVG renderer
  >
  >
  > He mentioned that the white background should be removed. He did **not** 
mention, that it should be made up of one filled path with no outline. ;-)
  >
  > > As for the 32px and 64px designs, I would much prefer using only two 
colors by placing white variants of the smaller icons on top of a blue document 
background. 
  > >  I think this fits much better with other Breeze mimetype icons.
  >
  > ndavis saw this differently:
  >
  > In D23464#521662 , @ndavis wrote:
  >
  > > I think we should use `#1ed4e5` for the color instead since that's what 
the official logo uses. Normally, I'd say to use a similar Breeze-like color, 
but mimetype icons are a mess anyway and I don't think it's worth worrying too 
much about unless Breeze's official color palette is expanded.
  >
  >
  > If we go with your suggestion, I think the outer ring should be dropped 
completely as it distracts more from the root / original branding than it 
benefits IMHO, like that: F7296477: Screenshot_20190830_15.png 

  >
  > It looks "Breezie" to me. :)
  
  
  Alright, try it without the ring. I thought the ring was necessary for it to 
make the original branding. Removing the ring allows the "root" symbol in the 
middle to be larger, which makes it less faint.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde added a reviewer: ngraham.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde added a comment.


  In D23464#522270 , @trickyricky26 
wrote:
  
  > As @noahdvs mentioned above, the white background should be removed and the 
entire symbol should be made up of one filled path with no outline (!). This is 
important to keep the icon looking as intended with the Qt SVG renderer
  
  
  He mentioned that he white background should be removed. He did **not** 
mention, that it should be made up of one filled path with no outline. ;-)
  
  > As for the 32px and 64px designs, I would much prefer using only two colors 
by placing white variants of the smaller icons on top of a blue document 
background. 
  >  I think this fits much better with other Breeze mimetype icons.
  
  ndavis saw this differently:
  
  In D23464#521662 , @ndavis wrote:
  
  > I think we should use `#1ed4e5` for the color instead since that's what the 
official logo uses. Normally, I'd say to use a similar Breeze-like color, but 
mimetype icons are a mess anyway and I don't think it's worth worrying too much 
about unless Breeze's official color palette is expanded.
  
  
  If we go with your suggestion, I think the outer ring should be dropped 
completely as it distracts more from the root / original banding than it 
benefits IMHO.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[TrickyRicky]

trickyricky26 added a comment.


  My thoughts on your submission:
  
  For the 16px and 22px designs, I would with the designs @ndavis proposed here:
  
  In D23464#521662 , @ndavis wrote:
  
  > F7290924: mimetypes.tar.gz 
  
  
  Yes, the symbol there has the same thickness throughout the root sign, which 
differs from the original branding, but this makes the icon much more 
discernable and it's not like you could make out that difference at that size 
anyway.
  As @noahdvs mentioned above, the white background should be removed and the 
entire symbol should be made up of one filled path with no outline (!). This is 
important to keep the icon looking as intended with the Qt SVG renderer.
  
  As for the 32px and 64px designs, I would much prefer using only two colors 
by placing white variants of the smaller icons on top of a blue document 
background. 
  Example for the 32px icon:
  F7293342: application-x-root-32.png 
  
  I think this fits much better with other Breeze mimetype icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde added a comment.


  > The 16 and 22 px versions aren't supposed to have backgrounds and the root 
symbols are pretty faint.
  
  Rethinking it, I think it's wrong. The white background belongs to the logo 
and should not be removed as the white circle and the root symbol belong 
together, even
  if it is against the Breeze guide line. ;)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde updated this revision to Diff 64946.
alexde added a comment.


  Add new 32px icons.
  
  The root is now less faint and uses the original color.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23464?vs=64944=64946

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-root.svg
  icons-dark/mimetypes/22/application-x-root.svg
  icons-dark/mimetypes/32/application-x-root.svg
  icons-dark/mimetypes/64/application-x-root.svg
  icons/mimetypes/16/application-x-root.svg
  icons/mimetypes/22/application-x-root.svg
  icons/mimetypes/32/application-x-root.svg
  icons/mimetypes/64/application-x-root.svg

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde updated this revision to Diff 64944.
alexde added a comment.


  Also add the new 64px breeze icon.
  Add new 22 px icons. Transparent background, less faint, original color.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23464?vs=64935=64944

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-root.svg
  icons-dark/mimetypes/22/application-x-root.svg
  icons-dark/mimetypes/32/application-x-root.svg
  icons-dark/mimetypes/64/application-x-root.svg
  icons/mimetypes/16/application-x-root.svg
  icons/mimetypes/22/application-x-root.svg
  icons/mimetypes/32/application-x-root.svg
  icons/mimetypes/64/application-x-root.svg

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde added a comment.


  In D23464#521662 , @ndavis wrote:
  
  > I think we should use `#1ed4e5` for the color instead since that's what the 
official logo uses. Normally, I'd say to use a similar Breeze-like color, but 
mimetype icons are a mess anyway and I don't think it's worth worrying too much 
about unless Breeze's official color palette is expanded.
  
  
  I have changed the color  for the 64px version. I think we can keep the blue 
background color as this is indeed the offical background color.
  
  > The 16 and 22 px versions aren't supposed to have backgrounds and the root 
symbols are pretty faint.
  
  Uh, I will make them somehow less faint, though I am not sure how to keep 
their original character in this case.
  
  >   I've remade these for you:
  > 
  > F7290924: mimetypes.tar.gz 
  
  Thanks, but the root you created does not resemble the original one any 
longer. However, I will rework them as well.
  
  > The 32px version isn't lined up with the grid and the emblem in the middle 
is faint. Generally, one should avoid placing objects on half pixels.
  
  I will see what I can do about it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde updated this revision to Diff 64935.
alexde added a comment.


  Improve the root logo layout and change the root's color to the offical color 
1ED4E5

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23464?vs=64668=64935

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-root.svg
  icons-dark/mimetypes/22/application-x-root.svg
  icons-dark/mimetypes/32/application-x-root.svg
  icons-dark/mimetypes/64/application-x-root.svg
  icons/mimetypes/16/application-x-root.svg
  icons/mimetypes/22/application-x-root.svg
  icons/mimetypes/32/application-x-root.svg
  icons/mimetypes/64/application-x-root.svg

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I think we should use `#1ed4e5` for the color instead since that's what the 
official logo uses. Normally, I'd say to use a similar Breeze-like color, but 
mimetype icons are a mess anyway and I don't think it's worth worrying too much 
about unless Breeze's official color palette is expanded.
  
  The 16 and 22 px versions aren't supposed to have backgrounds and the root 
symbols are pretty faint. I've remade these for you:
  
  F7290924: mimetypes.tar.gz 
  
  The 32px version isn't lined up with the grid and the emblem in the middle is 
faint. Generally, one should avoid placing objects on half pixels.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde created this revision.
alexde added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alexde requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-root.svg
  icons-dark/mimetypes/22/application-x-root.svg
  icons-dark/mimetypes/32/application-x-root.svg
  icons-dark/mimetypes/64/application-x-root.svg
  icons/mimetypes/16/application-x-root.svg
  icons/mimetypes/22/application-x-root.svg
  icons/mimetypes/32/application-x-root.svg
  icons/mimetypes/64/application-x-root.svg

To: alexde, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns