D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[Nathaniel Graham]

ngraham added a dependent revision: D23730: Add new protocol for 7z archives.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

To: nhiga, #frameworks, cfeck, pino, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:509640f8e185: [KUrlNavigator] Add MIME types supported by 
krarc to isCompressedPath (authored by nhiga, committed by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23490?vs=64731=65431

REVISION DETAIL
  https://phabricator.kde.org/D23490

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp

To: nhiga, #frameworks, cfeck, pino, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

To: nhiga, #frameworks, cfeck, pino, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[N. Higa]

nhiga added a comment.


  When this patch is applied and Krusader is not installed:
  
  Dolphin (with "Open archives as folder" enabled): Opens the 7z/RAR archive 
using Ark.
  Gwenview: 7z/RAR archives will not appear (probably because it is unsupported 
without krarc).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

To: nhiga, #frameworks, cfeck, pino, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[N. Higa]

nhiga edited the summary of this revision.
nhiga edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

To: nhiga, #frameworks, cfeck, pino, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[David Faure]

dfaure added a comment.


  What happens if krarc isn't installed? We try and fail and move on silently 
as if nothing happened, so this patch is indeed harmless? I see it's your test 
plan, but I want to be sure of what actually happens.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

To: nhiga, #frameworks, cfeck, pino, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited reviewers, added: Frameworks, cfeck, pino, dfaure; removed: 
kde-frameworks-devel.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

To: nhiga, #frameworks, cfeck, pino, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[N. Higa]

nhiga added a comment.


  This patch may be related to Bug 411330 
.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

To: nhiga, kde-frameworks-devel
Cc: LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[N. Higa]

nhiga created this revision.
nhiga added a reviewer: kde-frameworks-devel.
nhiga added a project: Frameworks.
nhiga requested review of this revision.

REVISION SUMMARY
  With D23476 , this patch should let users 
who have Krusader installed to view files inside a 7z or RAR archive in KDE 
applications (such as Gwenview) without decompressing the whole archive to 
another location. They will also be able to navigate the archive using Dolphin.

TEST PLAN
  1. Apply D23476  (and add 
`application/vnd.rar` to `archiveMimetype` in `krArc/krarc.protocol` if it does 
not work) to Krusader.
  2. Apply this patch to KIO.
  3. Enable "Open archives as folder" in Dolphin, then open a 7z/RAR file. It 
should be using the `krarc` protocol.
  4. Browse (Navigate) and look around the archive. Click on the breadcrumb in 
the location area for a parent folder which is outside the archive to make sure 
Bug 386448 does not occur.
  5. Open Gwenview and view a 7z/RAR archive with photos. Browse and view an 
image inside the archive.
  6. To be safe, uninstall Krusader and see if there is any bug if `krarc` is 
unavailable.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp

To: nhiga, kde-frameworks-devel
Cc: LeGast00n, GB_2, michaelh, ngraham, bruns