D23917: Use const_iterator

This revision was automatically updated to reflect the committed changes. Closed by commit R127:28841048d555: Use const_iterator (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=66021&id=66027 REVISION DETAIL https://phabricat

D23917: Use const_iterator

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D23917 To: gladhorn, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23917: Use const_iterator

gladhorn updated this revision to Diff 66021. gladhorn edited the summary of this revision. gladhorn removed subscribers: broulik, zzag. gladhorn added a comment. Fixed two missing spots REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=65946&id=6602

D23917: Use const_iterator

gladhorn added a comment. Yes, for me always using constBegin/constEnd makes reading the code slightly easier. INLINE COMMENTS > zzag wrote in registry.cpp:879 > constEnd Thanks! > zzag wrote in output_interface.cpp:119 > constEnd Thanks! REPOSITORY R127 KWayland REVISION DETAIL htt

D23917: Use const_iterator

zzag added a comment. In D23917#530297 , @broulik wrote: > If the container is `const` already there's no real reason to explicitly use `constBegin` which is effectively the same Yes, however it's still a good idea to be explicit about it

D23917: Use const_iterator

broulik added a comment. If the container is `const` already there's no real reason to explicitly use `constBegin` which is effectively the same REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23917 To: gladhorn, #kwin Cc: broulik, zzag, kde-frameworks-devel, LeGas

D23917: Use const_iterator

zzag added inline comments. INLINE COMMENTS > registry.cpp:879 > }); > if (it == m_interfaces.end()) { > qCDebug(KWAYLAND_CLIENT) << "Don't have interface " << > int(interface) << "with name " << name << "and minimum version" << version; constEnd REPOSITORY R127 KWayland

D23917: Use const_iterator

zzag added inline comments. INLINE COMMENTS > output_interface.cpp:119 > +auto rit = std::find_if(resources.constBegin(), > resources.constEnd(), [native] (const ResourceData &data) { return > data.resource == native; }); > if (rit != resources.end()) { > return (*

D23917: Use const_iterator

gladhorn updated this revision to Diff 65946. gladhorn added a comment. fixup REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=65945&id=65946 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23917 AFFECTED FILES src/client/plasmaw

D23917: Use const_iterator

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When trivial, replace iterators with the const versrion. REPOSITORY R127 KWayland