D24430: [KCModuleLoader] Show error when QML fails to load

2019-10-08 Thread Kai Uwe Broulik 
broulik closed this revision.
broulik added a comment.


  
https://cgit.kde.org/kcmutils.git/commit/?id=8cea2dacd80565f6d22bf1e5151e5c7be1620eab

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D24430

To: broulik, #plasma, ngraham, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24430: [KCModuleLoader] Show error when QML fails to load

2019-10-08 Thread Marco Martin 
mart accepted this revision.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D24430

To: broulik, #plasma, ngraham, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24430: [KCModuleLoader] Show error when QML fails to load

2019-10-06 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D24430

To: broulik, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24430: [KCModuleLoader] Show error when QML fails to load

2019-10-05 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Currently it just prints a warning to console and shows an empty dialog 
leaving the user wondering.

TEST PLAN
  Depends on D24429 
  F7522827: Screenshot_20191001_225332.png 

  Not pretty but better than nothing :)

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D24430

AFFECTED FILES
  src/kcmoduleloader.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns