This revision was automatically updated to reflect the committed changes.
Closed by commit R293:34e682a1c0ed: Move URL parsing methods from kioslave to
query object (authored by iasensio).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24433?vs=71523=71531
bruns accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
extend_query_url
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven, ngraham, astippich, bruns
Cc: broulik, bruns, kde-frameworks-devel, #dolphin,
iasensio updated this revision to Diff 71523.
iasensio marked 5 inline comments as done.
iasensio added a comment.
- Use return statements
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24433?vs=69836=71523
BRANCH
extend_query_url
REVISION DETAIL
bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.
just nitpicks ...
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven, ngraham, astippich, bruns
Cc: broulik, bruns,
bruns added inline comments.
INLINE COMMENTS
> query.cpp:342
> +QString jsonString = urlQuery.queryItemValue(QStringLiteral("json"),
> QUrl::FullyDecoded);
> +q = Query::fromJSON(jsonString.toUtf8());
> +} else if (urlQuery.hasQueryItem(QStringLiteral("query"))) {
just
ngraham accepted this revision.
ngraham added a comment.
Let's do this unless @bruns objects soon. :)
REPOSITORY
R293 Baloo
BRANCH
extend_query_url
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven, ngraham, astippich
Cc: broulik, bruns,
ngraham added a comment.
@bruns, is this good to go now?
REPOSITORY
R293 Baloo
BRANCH
extend_query_url
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven, ngraham, astippich
Cc: broulik, bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs,
iasensio added inline comments.
INLINE COMMENTS
> bruns wrote in kio_search.cpp:88
> @broulik - why `endsWith()`?
should I just change the comparisons to `path == ...`, just like the
`/documents` one?
REPOSITORY
R293 Baloo
BRANCH
extend_query_url
REVISION DETAIL
iasensio updated this revision to Diff 69836.
iasensio added a comment.
Remove extra spaces
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24433?vs=69613=69836
BRANCH
extend_query_url
REVISION DETAIL
https://phabricator.kde.org/D24433
AFFECTED FILES
bruns added a subscriber: broulik.
bruns added inline comments.
INLINE COMMENTS
> kio_search.cpp:88
> -return jsonQueryForType(QStringLiteral("Document"));
> -} else if (path.endsWith(QLatin1String("/images"))) {
> -return jsonQueryForType(QStringLiteral("Image"));
@broulik
iasensio updated this revision to Diff 69613.
iasensio marked 2 inline comments as done.
iasensio added a comment.
Simplify helper function
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24433?vs=67361=69613
BRANCH
extend_query_url
REVISION DETAIL
bruns added inline comments.
INLINE COMMENTS
> query.cpp:317
> +{
> +const QString jsonQuery(QStringLiteral("{\"dayFilter\": 0,\
> + \"monthFilter\": 0, \
dayFilter/monthFilter/yearFilter are pointless, as they just default, but have
to be parsed
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.
Seems good to me.
Tested and works
REPOSITORY
R293 Baloo
BRANCH
extend_query_url
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven, ngraham, astippich
meven added a reviewer: astippich.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven, ngraham, astippich
Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,
meven added a reviewer: ngraham.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven, ngraham
Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
iasensio removed a dependent revision: D25130: [dolphin/search] Search by
(multiple) tags.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven
Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n,
fbampaloukas, GB_2, domson,
iasensio added a dependent revision: D25130: [dolphin/search] Search by
(multiple) tags.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven
Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n,
fbampaloukas, GB_2, domson,
iasensio added a comment.
Friday ping
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven
Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
iasensio edited the summary of this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven
Cc: kde-frameworks-devel, #dolphin, lots0logs, LeGast00n, fbampaloukas, GB_2,
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,
iasensio created this revision.
iasensio added reviewers: Baloo, meven.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
iasensio requested review of this revision.
REVISION SUMMARY
This allows for query objects generated from
20 matches
Mail list logo
