D24932: Add Button to open the folder in filelight for more details

2019-12-27 Thread Shubham
shubham updated this revision to Diff 72261. shubham edited the summary of this revision. shubham added a comment. Fix whitespaces and crash condition REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24932?vs=72254=72261 BRANCH file REVISION DETAIL

D24932: Add Button to open the folder in filelight for more details

2019-12-27 Thread Shubham
shubham marked 9 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ngraham, #frameworks Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D24932: Add Button to open the folder in filelight for more details

2019-12-27 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. We're getting there, but this code now causes a crash that must be fixed. Please make sure you are testing your changes for all conditions (i.e. don't just make sure that it

D24932: Add Button to open the folder in filelight for more details

2019-12-27 Thread Shubham
shubham retitled this revision from "[WIP]: Add Button to open the folder in filelight for more details" to "Add Button to open the folder in filelight for more details". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24932 To: shubham, ngraham, #frameworks Cc: