D25049: Conditionally show navigation buttons in the header for multi-page KCMs

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R295:47f23c0f6ad1: Conditionally show navigation buttons in 
the header for multi-page KCMs (authored by ngraham).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25049?vs=68988=69138

REVISION DETAIL
  https://phabricator.kde.org/D25049

AFFECTED FILES
  src/kcmoduleqml.cpp

To: ngraham, #vdg, #plasma, mart
Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

[Nathaniel Graham]

ngraham added a comment.


  No regressions found and seems low-risk. Landing now to get it into 5.64 
ahead of tagging on Nov 2nd.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D25049

To: ngraham, #vdg, #plasma, mart
Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

[Björn Feber]

GB_2 added a comment.


  +1

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D25049

To: ngraham, #vdg, #plasma, mart
Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This makes the navigeability of multi-page KCMs completely obvious. The 
buttons only show
  up in multi-page KCMs where you've navigated into a sub-page, so there is no 
visual
  regression for anyone else.

TEST PLAN
  F7686630: demo-2019-10-29_11.19.01.webm 

REPOSITORY
  R295 KCMUtils

BRANCH
  show-navigation-buttons-when-necessary (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25049

AFFECTED FILES
  src/kcmoduleqml.cpp

To: ngraham, #vdg, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns