D25620: Register ActionType enum with metaobject system

2019-12-03 Thread Aleix Pol Gonzalez 
apol added a comment.


  Hi, thanks for your patience.
  
  Can you check if this works?
  https://phabricator.kde.org/D25727
  
  Can you share a test case that uses it?

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D25620

To: jbbgameich, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25620: Register ActionType enum with metaobject system

2019-12-03 Thread Jonah Brüchert 
jbbgameich added a comment.


  Ping

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D25620

To: jbbgameich, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25620: Register ActionType enum with metaobject system

2019-11-30 Thread Jonah Brüchert 
jbbgameich added inline comments.

INLINE COMMENTS

> apol wrote in personactionsmodel_p.h:24
> Why do we need the include?

The enum ist defined in that header.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D25620

To: jbbgameich, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25620: Register ActionType enum with metaobject system

2019-11-30 Thread Aleix Pol Gonzalez 
apol added a comment.


  the Q_ENUM looks good.

INLINE COMMENTS

> personactionsmodel_p.h:24
>  
> +#include "widgets/actions.h"
> +

Why do we need the include?

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D25620

To: jbbgameich, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25620: Register ActionType enum with metaobject system

2019-11-29 Thread Jonah Brüchert 
jbbgameich added a reviewer: apol.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D25620

To: jbbgameich, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25620: Register ActionType enum with metaobject system

2019-11-29 Thread Jonah Brüchert 
jbbgameich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jbbgameich requested review of this revision.

REPOSITORY
  R307 KPeople

BRANCH
  actions-meta-enum (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25620

AFFECTED FILES
  src/declarative/personactionsmodel.cpp
  src/declarative/personactionsmodel_p.h

To: jbbgameich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns