D25650: Port foreach

2019-12-01 Thread Nicolas Fella 
nicolasfella marked an inline comment as done.
nicolasfella added inline comments.

INLINE COMMENTS

> apol wrote in CMakeLists.txt:72
> This comment looks wrong

Fixed

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25650

To: nicolasfella, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25650: Port foreach

2019-12-01 Thread Nicolas Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:6ba0d9371f74: Port foreach (authored by nicolasfella).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25650?vs=70664=70682

REVISION DETAIL
  https://phabricator.kde.org/D25650

AFFECTED FILES
  CMakeLists.txt
  src/kaboutapplicationpersonlistdelegate_p.cpp
  src/kkeysequencewidget.cpp
  src/kmainwindow.cpp
  src/ktoolbar.cpp
  src/ktoolbarhandler.cpp
  src/kxmlguifactory.cpp
  src/kxmlguifactory_p.cpp

To: nicolasfella, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25650: Port foreach

2019-12-01 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:72
>  add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00)
>  # Subdirectories
>  add_definitions(-DTRANSLATION_DOMAIN=\"kxmlgui5\")

This comment looks wrong

REPOSITORY
  R263 KXmlGui

BRANCH
  fore

REVISION DETAIL
  https://phabricator.kde.org/D25650

To: nicolasfella, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25650: Port foreach

2019-12-01 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

TEST PLAN
  Builds, tests pass, dolphin opens

REPOSITORY
  R263 KXmlGui

BRANCH
  fore

REVISION DETAIL
  https://phabricator.kde.org/D25650

AFFECTED FILES
  CMakeLists.txt
  src/kaboutapplicationpersonlistdelegate_p.cpp
  src/kkeysequencewidget.cpp
  src/kmainwindow.cpp
  src/ktoolbar.cpp
  src/ktoolbarhandler.cpp
  src/kxmlguifactory.cpp
  src/kxmlguifactory_p.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns