D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-13 Thread Filip Fila 
filipf added a comment.


  In D25699#576444 , @fvogt wrote:
  
  > This fixed the button label, but the menu itself is unsuable due to a black 
text on dark background: 
https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21
  
  
  We've had several bugs due to the QQC2 and PC3 port and with the (LTS) 
release date being closer, we've reverted that port for now.
  
  We'll have to figure this out at some point in the future though.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-12 Thread Fabian Vogt 
fvogt added a comment.


  This fixed the button label, but the menu itself is unsuable due to a black 
text on dark background: 
https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-11 Thread Filip Fila 
filipf added a comment.


  Let's track the arrow issue in: https://bugs.kde.org/show_bug.cgi?id=415049

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-11 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e4e1613b0fe7: [PC3 ToolButton] Have the label take into 
account complementary color schemes (authored by filipf).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25699?vs=70789=71268

REVISION DETAIL
  https://phabricator.kde.org/D25699

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-11 Thread Filip Fila 
filipf edited the summary of this revision.
filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-11 Thread Fabian Vogt 
fvogt added a comment.


  In D25699#575278 , @davidedmundson 
wrote:
  
  > Please don't link external sites (GitHub) in the committed message.
  >
  > RE: Menu
  >  There is nothing in QQC2::Button to add a menu
  >
  > If we want that it would have to be a custom button subclass, rather than 
something we support in the style.
  
  
  Or as a simple hack for this case, adding "▾" to the button's label.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-11 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.


  Please don't link external sites (GitHub) in the committed message.
  
  RE: Menu
  There is nothing in QQC2::Button to add a menu
  
  If we want that it would have to be a custom button subclass, rather than 
something we support in the style.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-09 Thread Filip Fila 
filipf added subscribers: davidedmundson, mart.
filipf added a comment.


  Yeah, PC2 ToolButton has this so it loads the arrow: 
https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ToolButtonStyle.qml#L110
  
  For PC3 I guess we would have to hack it in in the sddm-theme code...
  
  @mart and @davidedmundson are there plans for PC3 to have a menu property 
like PC2?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-07 Thread Filip Fila 
filipf added a comment.


  In D25699#573713 , @fvogt wrote:
  
  > The check for the prefix was added in 
`bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc`, while the `control.flat` one got 
added much earlier.
  >
  > The labels are visible again with just the `control.flat` condition, but 
the prefix one might be needed as well for non-breeze themes.
  >
  > There's a part missing though, the triangle (visible on 
https://openqa.opensuse.org/tests/1105226#step/start_wayland_plasma5/21) is 
gone. That seems to be a feature lost with PC3 :-(
  
  
  Thanks for looking into the patch.
  
  Yeah, the triangle seems to be missing :/ possibly because PC2 has a menu 
property and PC3 doesn't... I will investigate further.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: fvogt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-07 Thread Fabian Vogt 
fvogt added a comment.


  The check for the prefix was added in 
`bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc`, while the `control.flat` one got 
added much earlier.
  
  The labels are visible again with just the `control.flat` condition, but the 
prefix one might be needed as well for non-breeze themes.
  
  There's a part missing though, the triangle (visible on 
https://openqa.opensuse.org/tests/1105226#step/start_wayland_plasma5/21) is 
gone. That seems to be a feature lost with PC3 :-(

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: fvogt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-07 Thread Filip Fila 
filipf edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-02 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-02 Thread Filip Fila 
filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-02 Thread Filip Fila 
filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-02 Thread Filip Fila 
filipf edited the test plan for this revision.
filipf added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-02 Thread Filip Fila 
filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  We've ported the SDDM theme to PC3 and now have black labels in PC3 
ToolButtons (keyboard and session button).
  
  The SDDM theme uses a complementary color scheme, which is something the PC2 
ToolButton respects and turns the labels white.
  
  Therefore I just copy pasted PC2's label color code to its PC3 counterpart: 
https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ToolButtonStyle.qml

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: filipf
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns