D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

ngraham accepted this revision. ngraham added a comment. You're right, it was a local cache. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham Cc: ngraham, bruns, ndavis, davidre,

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

bruns added a comment. In D26555#591657 , @ngraham wrote: > Looks like this needs a bit of CMake work to stop installing the old icons: > > # from directory: /home/nate/kde/build/plasma-framework > gmake[2]: *** No rule to make target

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. In D26555#591657 , @ngraham wrote: > Looks like this needs a bit of CMake work to stop installing the old icons: > > # from directory: /home/nate/kde/build/plasma-framework > gmake[2]: *** No rule to

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

ngraham added a comment. Looks like this needs a bit of CMake work to stop installing the old icons: # from directory: /home/nate/kde/build/plasma-framework gmake[2]: *** No rule to make target '/home/nate/kde/src/plasma-framework/src/desktoptheme/air/icons/nepomuk.svg', needed by

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. @bruns @ngraham What do you two think about using the find icon as the search icon, given IIRC we used the find icon for search in Dolphin in the Oxygen-era/KDE4-era? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. There we go. Noticed there was a slight imperfection with the icon alignment in the previous edit so fixed that. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg, ndavis,

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev updated this revision to Diff 73235. The-Feren-OS-Dev added a comment. Rename 'nepomuk' Plasma Theme icons to 'search' and redesign Oxygen/Air 'search' icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev updated this revision to Diff 73233. The-Feren-OS-Dev added a comment. Rename 'nepomuk' Plasma Theme icons to 'search' REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26555?vs=73230=73233 BRANCH master REVISION DETAIL

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. *sigh* It seems scour-icon decided to nuke the layer names that made the icons identifiable, working on fixing that now. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg,

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. ^ that was just me scour-icon'ing the SVG file as I forgot to initially. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham Cc: ngraham, bruns,

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev updated this revision to Diff 73230. The-Feren-OS-Dev added a comment. Rename 'nepomuk' Plasma Theme icons to 'search' and restyle Oxygen/Air Search Icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev updated this revision to Diff 73229. The-Feren-OS-Dev added a comment. Rename 'nepomuk' Plasma Theme icons to 'search' and restyle Oxygen/Air's icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26555?vs=73225=73229

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. Hmph... Oxygen has a low-quality 'search' icon. I'll update the diff again in a bit to add a higher quality version of the icon in SVG form if I can find a higher quality SVG of the icon from Oxygen. REPOSITORY R242 Plasma Framework (Library) REVISION

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev updated this revision to Diff 73225. The-Feren-OS-Dev added a comment. Rename 'nepomuk' Plasma Theme icons to 'search' REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26555?vs=73161=73225 BRANCH master REVISION DETAIL

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

ngraham added a comment. Thanks! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham Cc: ngraham, bruns, ndavis, davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. Alright, I'll look into having a replacement icon for Oxygen/Air. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham Cc: ngraham, bruns, ndavis,

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

ngraham requested changes to this revision. ngraham added a comment. Are we sure this is the right approach? In the Breeze theme, the icon is the same as the generic magnifying glass search icon, but in the Oxygen and Breeze theme, it's some kind of paint splatter, which as @bruns suggests,

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. The nepomuk icon is completely inappropriate for a generic "search" icon. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To:

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. If anyone has any issues with removing the 'nepomuk' icon theming, please be sure to let me know so I can add them back in again on this patch to be alongside the 'search' theming to sort that issue out. It appears that no 1st-party Plasmoids I can see

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Icons in the desktop theme that are made to replace icons in the icon theme need to be kept up to date with the icon theme. I'm accepting this as it is, but if @davidre thinks we should

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma Cc: davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. In D26555#591132 , @davidre wrote: > In D26555#591131 , @The-Feren-OS-Dev wrote: > > > In D26555#591126 , @davidre

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

davidre added a comment. In D26555#591131 , @The-Feren-OS-Dev wrote: > In D26555#591126 , @davidre wrote: > > > I still think the proper fix was to investigate why the widget explorer didn't show

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev added a comment. In D26555#591126 , @davidre wrote: > I still think the proper fix was to investigate why the widget explorer didn't show an icon instead of randomly changing the icon it uses which can have potential impact on

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

davidre added a comment. I still think the proper fix was to investigate why the widget explorer didn't show an icon instead of randomly changing the icon it uses which can have potential impact on other themes REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

The-Feren-OS-Dev retitled this revision from "Rename nepomuk Plasma Theme icons to 'search'" to "Rename 'nepomuk' Plasma Theme icons to 'search'". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev Cc: kde-frameworks-devel,

D26555: Rename nepomuk Plasma Theme icons to 'search'

The-Feren-OS-Dev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. The-Feren-OS-Dev requested review of this revision. REVISION SUMMARY BUG: 416072 Since the Milou/Search applet changed its icon from 'nepomuk' to 'search', the