This revision was automatically updated to reflect the committed changes.
Closed by commit R241:76470c116640: Allow to handle apps with Terminal=True in
their desktop file, handle their… (authored by meven).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
meven added a comment.
> OK, scheme-handler replaces most of these uses. I think we should just
deprecate "helper protocols" (which either hardcode an exec line or abuse
mimetypes) and move it all to the scheme-handler mechanism.
I completely agree, we have a standardized way to handle
meven marked an inline comment as done.
REPOSITORY
R241 KIO
BRANCH
arcpatch-D26557
REVISION DETAIL
https://phabricator.kde.org/D26557
To: meven, ervin, ngraham, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
meven updated this revision to Diff 73490.
meven added a comment.
Remove uncorrect comment
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26557?vs=73449=73490
BRANCH
arcpatch-D26557
REVISION DETAIL
https://phabricator.kde.org/D26557
AFFECTED FILES
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> meven wrote in desktopexecparser.cpp:213
> > Can you call mimeTypes() instead of serviceTypes() here? I'm trying to
> > slowly split the two notions, after it all got
meven updated this revision to Diff 73449.
meven marked 7 inline comments as done.
meven added a comment.
Address review
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26557?vs=73182=73449
BRANCH
arcpatch-D26557
REVISION DETAIL
meven added inline comments.
INLINE COMMENTS
> dfaure wrote in desktopexecparser.cpp:213
> Move result of method call into local const variable. The usual
> range-for-detaches problem.
>
> Can you call mimeTypes() instead of serviceTypes() here? I'm trying to slowly
> split the two notions,
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Please add me as reviewer when touching my code in KIO. I almost didn't
notice this one.
INLINE COMMENTS
> desktopexecparser.cpp:213
> +// add x-scheme-handler/
> +for
meven updated this revision to Diff 73182.
meven added a comment.
Clean up
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26557?vs=73181=73182
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26557
AFFECTED FILES
meven updated this revision to Diff 73181.
meven added a comment.
Fix
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26557?vs=73179=73181
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26557
AFFECTED FILES
src/core/desktopexecparser.cpp
meven planned changes to this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26557
To: meven, ervin, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
meven created this revision.
meven added reviewers: ervin, ngraham, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.
REVISION SUMMARY
The Terminal field in .desktop file was not taken into account as the
meven edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26557
To: meven, ervin, ngraham, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
13 matches
Mail list logo
