vonreth added inline comments.
INLINE COMMENTS
> nicolasfella wrote in CMakeLists.txt:42
> This results in KStatusNotifierItem not being built on Windows. Is KSNI any
> useful on Windows at all?
Nope :D
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:424fc980d9e3: Reduce dependencies on Windows (authored by
vonreth).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26757?vs=73851=73866
REVISION DETAIL
nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.
Other than that looks good to me
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26757
To: vonreth, broulik, brute4s99,
nicolasfella added inline comments.
INLINE COMMENTS
> CMakeLists.txt:42
>
> -if (NOT ANDROID)
> +if (NOT ANDROID AND NOT WIN32)
> find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus)
This results in KStatusNotifierItem not being built on Windows. Is KSNI any
useful on Windows
vonreth added reviewers: broulik, brute4s99, vkrause.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D26757
To: vonreth, broulik, brute4s99, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
vonreth created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vonreth requested review of this revision.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26757
AFFECTED FILES
CMakeLists.txt
