D26951: Remove old code that is not used anymore

2020-02-02 Thread David Redondo 
davidre added a comment.


  I just took a look at KSelector and it actually inherits minimum and maximum 
properties from QAbstractSlider so we could just drop these custom properties 
for KF6

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26951

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26951: Remove old code that is not used anymore

2020-02-02 Thread David Redondo 
This revision was automatically updated to reflect the committed changes.
Closed by commit R265:db859852b577: Remove old code that is not used anymore 
(authored by davidre).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26951?vs=74856=74857

REVISION DETAIL
  https://phabricator.kde.org/D26951

AFFECTED FILES
  src/kconfigdialogmanager.cpp

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26951: Remove old code that is not used anymore

2020-02-02 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  arcpatch-D26951

REVISION DETAIL
  https://phabricator.kde.org/D26951

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26951: Remove old code that is not used anymore

2020-02-02 Thread David Redondo 
davidre updated this revision to Diff 74856.
davidre added a comment.


  Update comment

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26951?vs=74450=74856

BRANCH
  arcpatch-D26951

REVISION DETAIL
  https://phabricator.kde.org/D26951

AFFECTED FILES
  src/kconfigdialogmanager.cpp

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26951: Remove old code that is not used anymore

2020-02-02 Thread David Faure 
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I don't really know KConfigDialogManager. But indeed KSelector has properties 
with those names so if someone wanted to use e.g. KGradientSelector here it 
sounds like this would be useful -> just adjust the comment?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26951

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26951: Remove old code that is not used anymore

2020-01-28 Thread Kevin Ottens 
ervin added a comment.


  LGTM, better wait for @dfaure opinion though

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26951

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26951: Remove old code that is not used anymore

2020-01-27 Thread David Redondo 
davidre added a comment.


  If it's still something we ship than I think it is better to just change the 
comment

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26951

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26951: Remove old code that is not used anymore

2020-01-27 Thread David Edmundson 
davidedmundson added a comment.


  Does it affect:
  
  kwidgetsaddons/src/kselector.h:48
  
  (no idea what that is, just something grep found)

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26951

To: davidre, dfaure, ervin, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26951: Remove old code that is not used anymore

2020-01-27 Thread David Redondo 
davidre created this revision.
davidre added reviewers: dfaure, ervin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  According to the comment it was for Qt3 support which we don't support 
anymore.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  unused (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26951

AFFECTED FILES
  src/kconfigdialogmanager.cpp

To: davidre, dfaure, ervin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns