D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. In D27150#619735 , @bruns wrote: > You have ommited to update the minimum ECM version in all cases AFAICS. Because that bump is done by the release scripts, and I did not want to mess with them. In general

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

bruns added a comment. @kossebau - you have pushed commits depending on this change to several repositories, sometimes without waiting for acceptance, sometimes even bypassing Phabricator review completely. You have ommited to update the minimum ECM version in all cases AFAICS.

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

This revision was automatically updated to reflect the committed changes. Closed by commit R240:86041b6d8634: Add ecm_qt_install_logging_categories ecm_qt_export_logging_category (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27150?vs=75312=75421#toc REPOSITORY

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27270: Use ecm_qt_install_logging_categories over manual categories files. REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27269: Use ecm_qt_install_logging_categories over manual categories file. REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau updated this revision to Diff 75312. kossebau added a comment. Add support for also generating renamecategories files REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27150?vs=75069=75312 BRANCH addautomaticcategoriesgeneration

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. In D27150#608492 , @mlaurent wrote: > In D27150#608491 , @kossebau wrote: > > > In D27150#608318 , @mlaurent wrote: > > > >

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. In D27150#608491 , @kossebau wrote: > In D27150#608318 , @mlaurent wrote: > > > Yep you need to create a file name "foo.renamecategories" where you change the categorie

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. In D27150#608318 , @mlaurent wrote: > Yep you need to create a file name "foo.renamecategories" where you change the categorie name > > 1. old module namenew module name > > for example "log_mailfilteragent

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. Yep you need to create a file name "foo.renamecategories" where you change the categorie name old module namenew module name = for example "log_mailfilteragent org.kde.pim.mailfilteragent" in kmail What do you need

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. @mlaurent Wasn't there also something which tells kdebugsettings about renamed categories? Is that documented anywhere? Could that be supported by some additional macro or adaption of the existing/new ones? REPOSITORY R240 Extra CMake Modules BRANCH

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. Good. So will land this next Tuesday, Feb 11th then, so other people will have had 7 days of feedback opportunity. REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. I don't see other case. For me your macro works for all case that we can implement. No other idea. But avoiding to create by hand the file is a good idea. I never successed to create a macro for it So thanks REPOSITORY R240 Extra CMake Modules BRANCH

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. @mlaurent Thanks for review :) Do you happen to know any more complex usages of ecm_qt_declare_logging_category and/or manual category definitions which can and should be checked for how these new methods would work out? I have not really researched bigger parts

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me :) REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27178: Use ecm_qt_install_logging_categories over manual categories file. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau updated this revision to Diff 75069. kossebau added a comment. in doc also be explicit that ecm_qt_install_logging_categories can be in another directory, just needs to be called last REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. Seems ok for me REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a comment. See D27150 as an example next to the test and docs for how this would be used. The ecm_qt_export_logging_category also is kept similar to ecm_qt_declare_logging_category in case someone wants to turn the manual definition to a

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added a dependent revision: D27151: Use ecm_qt_install_logging_categories over manual categories file. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau added inline comments. INLINE COMMENTS > ECMQtDeclareLoggingCategory.cmake:76 > +# FILE > +# DESTINATION > +# [SORT] Why the need for explicit DESTINATION argument, where almost all use-cases will use ${KDE_INSTALL_LOGGINGCATEGORIESDIR}? Because

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Having to