D27158: Fix some compiler warnings

2020-04-21 Thread Ahmad Samir 
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:fb29718d3ac6: Fix some compiler warnings (authored by 
ahmadsamir).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27158?vs=80753=80754

REVISION DETAIL
  https://phabricator.kde.org/D27158

AFFECTED FILES
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27158: Fix some compiler warnings

2020-04-21 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 80753.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27158?vs=75028=80753

BRANCH
  l-compiler-warnings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27158

AFFECTED FILES
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27158: Fix some compiler warnings

2020-02-08 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  l-compiler-warnings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27158

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27158: Fix some compiler warnings

2020-02-05 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 75028.
ahmadsamir added a comment.


  Add missing space after ,

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27158?vs=75009=75028

BRANCH
  l-compiler-warnings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27158

AFFECTED FILES
  src/core/kconfig.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27158: Fix some compiler warnings

2020-02-04 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> KConfigCodeGeneratorBase.cpp:45
>  ParseResult )
> -: m_inputFile(inputFile), m_baseDir(baseDir), m_fileName(fileName), 
> m_cfg(parameters), parseResult(parseResult)
> +: parseResult(parseResult), m_inputFile(inputFile),m_baseDir(baseDir), 
> m_fileName(fileName), m_cfg(parameters)
>  {

missing space before m_baseDir

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27158

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27158: Fix some compiler warnings

2020-02-04 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  - Fix order of member initialisation (compiling with -Wreorder)
  - Use Q_UNUSED where needed
  - QAtomicInteger::loadRelaxed() has been available since Qt 5.14

TEST PLAN
  make && ctest

REPOSITORY
  R237 KConfig

BRANCH
  l-compiler-warnings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27158

AFFECTED FILES
  src/core/kconfig.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns