D27320: enable anonymous and domain extra field in authinfo

2020-02-14 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:9d52cd9c9144: smb: enable anonymous and domain extra 
field in authinfo (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27320?vs=75466=75705#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27320?vs=75466=75705

REVISION DETAIL
  https://phabricator.kde.org/D27320

AFFECTED FILES
  smb/kio_smb.h
  smb/kio_smb_auth.cpp

To: sitter, ngraham, dfaure
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov


D27320: enable anonymous and domain extra field in authinfo

2020-02-11 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I also cannot test this properly, but the code change looks appropriate.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327484

REVISION DETAIL
  https://phabricator.kde.org/D27320

To: sitter, ngraham, dfaure
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov


D27320: enable anonymous and domain extra field in authinfo

2020-02-11 Thread Harald Sitter
sitter created this revision.
sitter added reviewers: ngraham, dfaure.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this causes kiod to query the password with the relevant functionality
  enabled. domain additionally defaults to whatever smbc_getWorkgroup returns
  
  BUG: 327484
  FIXED-IN: 19.12.3

TEST PLAN
  - builds
  - auth query has new functionality
  - logging in still works as expected
  
  I couldn't actually get the original problem in 327484 to appear with a samba 
DC I threw together, so for all I know this doesn't actually fix the bug but I 
have no way to test :|

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327484

REVISION DETAIL
  https://phabricator.kde.org/D27320

AFFECTED FILES
  smb/kio_smb.h
  smb/kio_smb_auth.cpp

To: sitter, ngraham, dfaure
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov