D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

2020-02-14 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:a813d67cf6af: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27378?vs=75630=75706#toc REPOSITORY R320 KIO Extras CHANGES

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

2020-02-14 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Gotcha, thanks for the explanation. Makes sense now. REPOSITORY R320 KIO Extras BRANCH bug417166 REVISION DETAIL https://phabricator.kde.org/D27378 To: sitter, ngraham Cc:

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

2020-02-14 Thread Harald Sitter
sitter added a comment. Nah. 50.50.50.50 is an actual host on the internet for all your router knows ^^ You need to use an unassigned address within your actual home network, otherwise your router will (likely) send it off to the internet and then it will bounce around there for a bit

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

2020-02-13 Thread Nathaniel Graham
ngraham added a comment. So like this? F8101694: Screenshot_20200213_130357.png Hmm, I'm not really sure. For one "timeout on server" is pretty jargonistic. Also, in this case, there is no server! I think the "Could not connect to host for "

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

2020-02-13 Thread Harald Sitter
sitter added a comment. Use an ip address that isn't used by anything. Failing to resolve the hostname is different from failing to contact an ip address i.e. "I dunno who this is" versus "you have called a number that has been disconnected or is no longer in service". REPOSITORY R320

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

2020-02-13 Thread Nathaniel Graham
ngraham added a comment. I tested out this patch by unplugging the network cable to the machine hosting my samba share and then trying to connect to it in Dolphin using the saved location in my Places panel where I access it from (`smb://gaston@living-room-pc/Users/gaston/Desktop/`) , but I

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

2020-02-13 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY same as the ftp does. in fact, also steal the error message