D27444: Added top area

niccolove updated this revision to Diff 77407. niccolove added a comment. Changed filename to heading REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77272=77407 BRANCH top_area (branched from master) REVISION DETAIL

D27444: Added top area

ngraham added a comment. The actual component is called `PlasmoidHeading`, but this file is `PlasmoisHeader`. Maybe they should match? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart,

D27444: Added top area

niccolove updated this revision to Diff 77272. niccolove added a comment. Renamed file as plasmoidheader and used scour REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=76562=77272 BRANCH top_area (branched from master)

D27444: Added top area

ngraham added a comment. Maybe run it through an SVG optimizer; See https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Scour REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart,

D27444: Added top area

niccolove updated this revision to Diff 76562. niccolove added a comment. Hardcoded colors REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=76378=76562 BRANCH top_area (branched from master) REVISION DETAIL

D27444: Added top area

niccolove added a dependent revision: D27695: WIP: Create a new TopArea element using widgets/toparea svg. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack,

D27444: Added top area

niccolove updated this revision to Diff 76378. niccolove added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=76376=76378 BRANCH top_area (branched from master) REVISION DETAIL

D27444: Added top area

niccolove updated this revision to Diff 76376. niccolove added a comment. Added toparea margins REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=75824=76376 BRANCH top_area (branched from master) REVISION DETAIL

D27444: Added top area

niccolove added a comment. In D27444#614762 , @mart wrote: > - i would provide one single svg with top and bottom areas so one can use something like that as a footer as well (and probably a frame that has nothing rounded) > - if you have a

D27444: Added top area

mart added a comment. i also wonder if the normal "toolbar2 element already existing can be used.. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27444: Added top area

mart added a comment. some considerations: - this toparea will need to "overflow" its parent for the exact distance needed to perfectly fuse with the background, and has to work with both dialogs and widgets-on-desktop (so we're kinda assuming those 2 backgrounds have the exact same

D27444: Added top area

ngraham added a comment. Oops, you're right! My mistake, sorry. Will resume the review. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27444: Added top area

niccolove added a comment. In D27444#612582 , @ngraham wrote: > This will need CMake changes to actually install it. Isn't this automatically done by the glob? FILE(GLOB widgets widgets/*.svg)

D27444: Added top area

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

niccolove updated this revision to Diff 75824. niccolove added a comment. Remove hardcoded values REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=75796=75824 BRANCH top_area (branched from master) REVISION DETAIL

D27444: Added top area

ngraham added a comment. This will need CMake changes to actually install it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

ngraham added inline comments. INLINE COMMENTS > toparea.svg:727 > + id="rect4138-7" > + > style="color:#eff0f1;opacity:0.75;fill:currentColor;fill-opacity:0.6;stroke:none" > /> > + Are these supposed to have hardcoded colors? REPOSITORY R242 Plasma Framework (Library)

D27444: Added top area

niccolove added a dependent revision: D27189: Created a top area based on widgets/toparea.svg. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27444: Added top area

niccolove added reviewers: VDG, ngraham, ndavis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Adds top area for D27189 REPOSITORY R242 Plasma Framework (Library) BRANCH