D27528: Adapt action numbering in Android to work like in KNotifications

[Nicolas Fella]

nicolasfella closed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[caca hueto]

cacahueto added a comment.


  I have tried all the suggested commands, none of them worked. I opened a new 
merge request where everything is correct:
  https://phabricator.kde.org/D27740
  
  Can you delete this merge request or tell me how I can do it?
  Sorry for the questions, but I have never worked with this system and coming 
from Git, I don't find it intuitive.

REPOSITORY
  R289 KNotifications

BRANCH
  adapt-action-numbering-in-android-as-in-knotifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[caca hueto]

cacahueto updated this revision to Diff 76684.
cacahueto added a comment.


  Adapt action numbering in Android to work like in KNotifications
  
  Summary:
  KNotifications assigns the ID 0 to the default action on a notification (the
  one when the notification itself is selected). Additional actions (buttons on
  the notification) are counted starting with 1.
  
  In the Android backend however, the default action has ID 0 and the additional
  actions are counted starting with 0 as well. This has been fixed to work as
  described above.
  
  Reviewers: #frameworks , 
nicolasfella, vkrause
  
  Subscribers: kde-frameworks-devel
  
  Tags: #frameworks 
  
  Differential Revision: https://phabricator.kde.org/D27528

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27528?vs=76065=76684

BRANCH
  adapt-action-numbering-in-android-as-in-knotifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27528

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[Nicolas Fella]

nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  Let's get this in. Can you please give me your full name and email address so 
I can merge this?

REPOSITORY
  R289 KNotifications

BRANCH
  adapt-action-numbering-in-android-as-in-knotifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[Nicolas Fella]

nicolasfella added a comment.


  To apply the changes made in the web interface to your local commit you use 
`arc amend` I think.
  
  To upload new changes you do `arc diff --update D27528`
  
  > Once the diff is landed, it will be commited with the email address you set 
up in your KDE Identity account afaik.
  
  It does not. It uses whatever authorship info is in the uploaded patch, which 
may be empty if the patch was uploaded via the web interface. Always check that 
if you are landing other people's patches!

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[Jonah Brüchert]

jbbgameich added a comment.


  Once the diff is landed, it will be commited with the email address you set 
up in your KDE Identity account afaik.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[caca hueto]

cacahueto added a comment.


  I added a summary here.
  
  I also wanted to fix it directly in the commit. Besides, I didn't set the 
committer e-mail address correctly, so I'd like to fix that as well.
  How can I edit the commit with `arc`? Or can I just `git commit --amend` and 
push?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[caca hueto]

cacahueto edited the summary of this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[Nicolas Fella]

nicolasfella added a comment.


  Thanks for the patch, makes sense.
  
  Please make the commit message a bit more elaborate

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[Jonah Brüchert]

jbbgameich added reviewers: nicolasfella, vkrause.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

[caca hueto]

cacahueto created this revision.
cacahueto added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cacahueto requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  adapt-action-numbering-in-android-as-in-knotifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27528

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java

To: cacahueto, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns