D27596: Load QM files from assets: URLs on Android

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:040504da64aa: Load QM files from assets: URLs on Android 
(authored by vkrause).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27596?vs=76212=76476

REVISION DETAIL
  https://phabricator.kde.org/D27596

AFFECTED FILES
  modules/ECMQmLoader.cpp.in

To: vkrause, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham, bruns

D27596: Load QM files from assets: URLs on Android

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  They used to work back when I added the code for it. Maybe it broke over 
time. If it works for you, go for it.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27596

To: vkrause, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham, bruns

D27596: Load QM files from assets: URLs on Android

[Volker Krause]

vkrause added a comment.


  In D27596#616554 , @apol wrote:
  
  > Don't we need an if Qt 5.13 elseif Qt 5.14?
  >
  > In other Qt versions it won't be in the assets...
  
  
  Are you sure about this? I had tested this on my Qt 5.13 setup and the files 
are in the same place there. I can't prove it with the binary factory apk 
though, translations don't seem to be included there at all?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D27596

To: vkrause
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham, bruns

D27596: Load QM files from assets: URLs on Android

[Aleix Pol Gonzalez]

apol added a comment.


  Don't we need an if Qt 5.13 elseif Qt 5.14?
  
  In other Qt versions it won't be in the assets...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D27596

To: vkrause
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham, bruns

D27596: Load QM files from assets: URLs on Android

[Volker Krause]

vkrause added a task: T12520: Qt 5.14.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D27596

To: vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27596: Load QM files from assets: URLs on Android

[Volker Krause]

vkrause created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This works with both the old and the new way of Qt's asset deployment, ie.
  with Qt 5.13 and Qt 5.14.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27596

AFFECTED FILES
  modules/ECMQmLoader.cpp.in

To: vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns