D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-27 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R273:1275529bc2d5: [UrlHandler] Handle opening the online docs for KCM modules (authored by ahmadsamir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27616?vs=76522=76555#toc REPOSITORY R273

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-27 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R273 KGuiAddons BRANCH l-urlhandler-optimi (branched from master) REVISION DETAIL https://phabricator.kde.org/D27616 To: ahmadsamir, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack,

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-27 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 76522. ahmadsamir added a comment. Really revert some changes REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27616?vs=76474=76522 BRANCH l-urlhandler-optimi (branched from master) REVISION DETAIL

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-26 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > CMakeLists.txt:33 > target_compile_definitions(KF5GuiAddons INTERFACE > "$") > -target_link_libraries(KF5GuiAddons PUBLIC Qt5::Gui) > +target_link_libraries(KF5GuiAddons PUBLIC Qt5::Widgets) > +target_link_libraries(KF5GuiAddons PUBLIC KF5::I18n)

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-26 Thread Ahmad Samir
ahmadsamir added a comment. In D27616#618382 , @apol wrote: > We can't add new dependencies to a tier1 framework, it would break the whole dependency system. > > Just make it a qCWarning. I opted for qDebug() for now, and will change

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 76474. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Don't change dependencies for a low tier framework REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27616?vs=76463=76474 BRANCH

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-26 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. We can't add new dependencies to a tier1 framework, it would break the whole dependency system. Just make it a qCWarning. REPOSITORY R273 KGuiAddons REVISION DETAIL

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 76463. ahmadsamir retitled this revision from "[UrlHandler] optimise the code and less if nesting" to "[UrlHandler] Handle opening the online docs for KCM modules". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this