D27840: Introduce SettingState* elements to ease KCM writing

This revision was automatically updated to reflect the committed changes. Closed by commit R296:24211925f835: Introduce SettingState* elements to ease KCM writing (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=80305=80654

D27840: Introduce SettingState* elements to ease KCM writing

davidedmundson accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27840: Introduce SettingState* elements to ease KCM writing

ervin updated this revision to Diff 80305. ervin added a comment. Fix issues found with Cyril's patches on various KCMs. REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=78698=80305 REVISION DETAIL https://phabricator.kde.org/D27840

D27840: Introduce SettingState* elements to ease KCM writing

crossi added a dependent revision: D28629: [WIP] Port KCM to SettingStateBinding. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: broulik, kde-frameworks-devel,

D27840: Introduce SettingState* elements to ease KCM writing

crossi added a dependent revision: D28622: [WIP] Port KCM KWin Decoration and VirtualDesktop to SettingStateBinding. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma

D27840: Introduce SettingState* elements to ease KCM writing

ervin updated this revision to Diff 78698. ervin marked 10 inline comments as done. ervin added a comment. Addresses Kai and David comments. REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=78469=78698 REVISION DETAIL

D27840: Introduce SettingState* elements to ease KCM writing

ervin marked 15 inline comments as done. ervin added inline comments. INLINE COMMENTS > broulik wrote in SettingStateBinding.qml:58 > This description didn't really help me in understanding what it does until I > read the code further down. Went for something much more verbose, but at least it

D27840: Introduce SettingState* elements to ease KCM writing

broulik added a comment. Cool INLINE COMMENTS > SettingStateBinding.qml:40 > + * target: Item > + * The graphical element which state we want to manage based on a setting > + */ *whose > SettingStateBinding.qml:58 > + * extraEnabledPredicate: bool > + * An extra

D27840: Introduce SettingState* elements to ease KCM writing

davidedmundson added inline comments. INLINE COMMENTS > SettingStateIndicator.qml:30 > +Item { > +id: root > + This is a faux-button. Which means it needs all the relevant: Accessible.blah roles to be manually added Should it be in the tab focus chain? (or we could just inherit

D27840: Introduce SettingState* elements to ease KCM writing

ervin updated this revision to Diff 78469. ervin added a comment. Have the indicators line up vertically automatically when applicable REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=77848=78469 REVISION DETAIL

D27840: Introduce SettingState* elements to ease KCM writing

ervin updated this revision to Diff 77848. ervin added a comment. Take feedback about the GUI into account REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=76952=77848 REVISION DETAIL https://phabricator.kde.org/D27840 AFFECTED FILES

D27840: Introduce SettingState* elements to ease KCM writing

bport accepted this revision. bport added a comment. This revision is now accepted and ready to land. From code POV this is ok, but neet to wait feedback from VDG to adapt state indicator REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi,

D27840: Introduce SettingState* elements to ease KCM writing

ervin added a comment. In D27840#622937 , @ngraham wrote: > This patch doesn't apply on top of KDeclarative for me: > > This diff is against commit 3d8757d5dfea2360304e2c8e7d0d575d04b00735, but > the commit is nowhere in the

D27840: Introduce SettingState* elements to ease KCM writing

ngraham added a comment. This patch doesn't apply on top of KDeclarative for me: This diff is against commit 3d8757d5dfea2360304e2c8e7d0d575d04b00735, but the commit is nowhere in the working copy. Try to apply it against the current working copy state?

D27840: Introduce SettingState* elements to ease KCM writing

ervin added a dependent revision: D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc:

D27840: Introduce SettingState* elements to ease KCM writing

ervin edited the summary of this revision. ervin added reviewers: Frameworks, Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel,

D27840: Introduce SettingState* elements to ease KCM writing

ervin created this revision. ervin added reviewers: crossi, hchain, meven, bport, davidedmundson, mart, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This is the QML based counterpart of