D27873: sftp: do not show creation time when we do not know it

2020-03-25 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:b13449a13b00: sftp: do not show creation time when we do not know it (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=78352=78444

D27873: sftp: do not show creation time when we do not know it

2020-03-24 Thread Stefan Brüns
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns, meven Cc: meven, bruns, kde-frameworks-devel, kfm-devel, nikolaik, pberestov,

D27873: sftp: do not show creation time when we do not know it

2020-03-24 Thread Stefan Brüns
bruns added a comment. Looks ok now. Should be followed up by a corresponding change for ACCESS_TIME/MODIFICATION_TIME - both are optional as well. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns, meven Cc: meven, bruns,

D27873: sftp: do not show creation time when we do not know it

2020-03-24 Thread Méven Car
meven accepted this revision. meven added a comment. Ok to me @bruns ? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns, meven Cc: meven, bruns, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n,

D27873: sftp: do not show creation time when we do not know it

2020-03-24 Thread Harald Sitter
sitter updated this revision to Diff 78352. sitter added a comment. . REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=77080=78352 BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 AFFECTED FILES sftp/kio_sftp.cpp To:

D27873: sftp: do not show creation time when we do not know it

2020-03-24 Thread Méven Car
meven added a comment. In D27873#624567 , @sitter wrote: > In D27873#623582 , @bruns wrote: > > > Please correct the comment in the code - it depends on the server SFTP implementation. > > >

D27873: sftp: do not show creation time when we do not know it

2020-03-16 Thread Harald Sitter
sitter added a comment. ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D27873: sftp: do not show creation time when we do not know it

2020-03-09 Thread Harald Sitter
sitter added a comment. In D27873#623582 , @bruns wrote: > Please correct the comment in the code - it depends on the server SFTP implementation. Birth time does not depend on the file system? REPOSITORY R320 KIO Extras REVISION

D27873: sftp: do not show creation time when we do not know it

2020-03-06 Thread Stefan Brüns
bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please correct the comment in the code - it depends on the server SFTP implementation. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To:

D27873: sftp: do not show creation time when we do not know it

2020-03-06 Thread Harald Sitter
sitter updated this revision to Diff 77080. sitter added a comment. use flaggy REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=77039=77080 BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 AFFECTED FILES

D27873: sftp: do not show creation time when we do not know it

2020-03-05 Thread Stefan Brüns
bruns added a comment. At least the openssh implementation apparently only supports atime/mtime: https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/sftp-common.c?rev=1.31=text/x-cvsweb-markup REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To:

D27873: sftp: do not show creation time when we do not know it

2020-03-05 Thread Stefan Brüns
bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Btrfs definitely does support birthtime INLINE COMMENTS > kio_sftp.cpp:496 > entry.fastInsert(KIO::UDSEntry::UDS_MODIFICATION_TIME, sb->mtime); > -

D27873: sftp: do not show creation time when we do not know it

2020-03-05 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack,

D27873: sftp: do not show creation time when we do not know it

2020-03-05 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY creation time (aka birth time) is file system dependent, if the fs