D27912: Draw inlineNotes after drawing word wrap marker

cullmann closed this revision. cullmann added a comment. Hmm, yes, seems to work again. Let's close this then again. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27912 To: davidre, #ktexteditor, brauch Cc: cullmann, brauch, kwrite-devel,

D27912: Draw inlineNotes after drawing word wrap marker

davidre added a comment. Seems in https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/314/ the test passed again? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27912 To: davidre, #ktexteditor, brauch Cc: cullmann, brauch,

D27912: Draw inlineNotes after drawing word wrap marker

davidre added a comment. In D27912#623891 , @brauch wrote: > I also don't understand this. Even if the painting somehow changes, e.g. because some painter state is set which wasnt set before (which I do not see to be the case here), that should

D27912: Draw inlineNotes after drawing word wrap marker

brauch added a comment. I also don't understand this. Even if the painting somehow changes, e.g. because some painter state is set which wasnt set before (which I do not see to be the case here), that should not affect the line layout, as that is computed separately. Very strange.

D27912: Draw inlineNotes after drawing word wrap marker

davidre added a comment. FAIL! : InlineNoteTest::testInlineNote() Compared values are not the same Actual (newCoordCol04): QPoint(51,1) Expected (coordCol04) : QPoint(33,1) I have node idea why the test would be failing. It complains that a coordinateToCursor changed. My

D27912: Draw inlineNotes after drawing word wrap marker

davidre added a comment. In D27912#623871 , @cullmann wrote: > Hi, could it be that killed the inline notes autotest? > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/313/ Sorry I will take a look

D27912: Draw inlineNotes after drawing word wrap marker

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Hi, could it be that killed the inline notes autotest? https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/313/ REPOSITORY R39 KTextEditor REVISION

D27912: Draw inlineNotes after drawing word wrap marker

This revision was automatically updated to reflect the committed changes. Closed by commit R39:875d4da5475f: Draw inlineNotes after drawing word wrap marker (authored by davidre). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27912?vs=77168=77173

D27912: Draw inlineNotes after drawing word wrap marker

brauch accepted this revision. brauch added a comment. This revision is now accepted and ready to land. Looks good, thanks! Yes, it's an improvement. REPOSITORY R39 KTextEditor BRANCH caret REVISION DETAIL https://phabricator.kde.org/D27912 To: davidre, #ktexteditor, brauch Cc:

D27912: Draw inlineNotes after drawing word wrap marker

davidre retitled this revision from "Draw inlineNotes after drawing caret" to "Draw inlineNotes after drawing word wrap marker". davidre edited the summary of this revision. davidre edited the test plan for this revision. davidre added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor

D27912: Draw inlineNotes after drawing word wrap marker

davidre edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27912 To: davidre, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann