This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:298ce0ed7ff4: Fix warnings (authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
apol marked an inline comment as done.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D28088
To: apol, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
ngraham, bruns
apol updated this revision to Diff 78630.
apol added a comment.
add const
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28088?vs=77795=78630
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28088
AFFECTED FILES
ahmadsamir added inline comments.
INLINE COMMENTS
> containmentactions.cpp:138
> #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)
> +int o =
> QObject::staticQtMetaObject.indexOfEnumerator("Orientations");
> +QMetaEnum orient = QObject::staticQtMetaObject.enumerator(o);
const ?
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
