D28088: Fix warnings

2020-04-13 Thread Aleix Pol Gonzalez 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:298ce0ed7ff4: Fix warnings (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28088?vs=78630=80058

REVISION DETAIL
  https://phabricator.kde.org/D28088

AFFECTED FILES
  src/plasma/containmentactions.cpp
  src/plasma/private/storagethread.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h

To: apol, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28088: Fix warnings

2020-03-27 Thread Aleix Pol Gonzalez 
apol marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28088

To: apol, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28088: Fix warnings

2020-03-27 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 78630.
apol added a comment.


  add const

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28088?vs=77795=78630

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28088

AFFECTED FILES
  src/plasma/containmentactions.cpp
  src/plasma/private/storagethread.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h

To: apol, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28088: Fix warnings

2020-03-16 Thread Ahmad Samir 
ahmadsamir added inline comments.

INLINE COMMENTS

> containmentactions.cpp:138
>  #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)
> +int o = 
> QObject::staticQtMetaObject.indexOfEnumerator("Orientations");
> +QMetaEnum orient = QObject::staticQtMetaObject.enumerator(o);

const ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28088

To: apol, #frameworks
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28088: Fix warnings

2020-03-16 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28088

AFFECTED FILES
  src/plasma/containmentactions.cpp
  src/plasma/private/storagethread.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h

To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns