D28202: [FileIndexerConfig] Replace config QString, bool pair with dedicated class

2020-03-25 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:7aacb80b23cc: [FileIndexerConfig] Replace config 
QString,bool pair with dedicated class (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28202?vs=78225=78477

REVISION DETAIL
  https://phabricator.kde.org/D28202

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28202: [FileIndexerConfig] Replace config QString, bool pair with dedicated class

2020-03-25 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28202

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28202: [FileIndexerConfig] Replace config QString, bool pair with dedicated class

2020-03-22 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  entry.path/entry.isIncluded is more readable than entry.first/enty.second.
  
  Also replace the homegrown insertSort with std::lower_bound + insert.

TEST PLAN
  ctest -R fileindexerconfigtest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28202

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams