D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bruns added a comment. In D28400#643965 , @bcooksley wrote: > Sorry, but that isn't how this works. Also, you will notice that one of the failing platforms is FreeBSD. Which is freely available and OSS. That does not change the fact it

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

vkrause added inline comments. INLINE COMMENTS > bruns wrote in searchstore.cpp:82 > Thanks for the heads-up. > > As you have noticed, the message is vague, so someone with access to one of > the affected systems should test it and submit a review. I don't have either of those here to test it

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bcooksley added a comment. Sorry, but that isn't how this works. Also, you will notice that one of the failing platforms is FreeBSD. Which is freely available and OSS. The responsibility of people to keep code compiling rests with those working on it. Should there be platform specific

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bruns added inline comments. INLINE COMMENTS > kossebau wrote in searchstore.cpp:82 > This might need an explicit `#include ` on some systems, not exactly > sure by the error message. > > At least with FreeBSD & Windows KDE CI fails over this: >

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bruns added a comment. In D28400#643934 , @bcooksley wrote: > The following is notice that the following reviews/commits are being scheduled to be reverted in 24 hours due to the FTBFS on Windows and FreeBSD: > > -

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bcooksley added a comment. The following is notice that the following reviews/commits are being scheduled to be reverted in 24 hours due to the FTBFS on Windows and FreeBSD: - 2b9c468816459a318dd2c8fe96e5e5acf1cedfd1

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

kossebau added inline comments. INLINE COMMENTS > searchstore.cpp:82 > +}; > +constexpr std::array internalProperties {{ > +{ "filename","F",QVariant::String }, This might need an explicit `#include ` on some systems, not exactly sure by the error message. At least with FreeBSD &

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

This revision was automatically updated to reflect the committed changes. Closed by commit R293:2b9c46881645: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28400?vs=78783=79584#toc REPOSITORY

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28400 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bruns added a dependent revision: D28401: [SearchStore] Handle double values in property queries. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28400 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The AdvancedQueryParser has no knowledge about the semantics of a value,