D28555: File ioslave : use Better setting for sendfile syscall

This revision was automatically updated to reflect the committed changes. Closed by commit R241:10cf5aca5b3d: File ioslave : use Better setting for sendfile syscall (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28555?vs=79284=79338 REVISION

D28555: File ioslave : use Better setting for sendfile syscall

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH sendfile-opt REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D28555: File ioslave : use Better setting for sendfile syscall

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH sendfile-opt REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D28555: File ioslave : use Better setting for sendfile syscall

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah sorry, I missed the fact that one doesn't actually need to call sendfile64() explicitly. And if sendfile fails we have a fall back, so yeah, might as well try in all cases.

D28555: File ioslave : use Better setting for sendfile syscall

bruns added a comment. In D28555#641390 , @dfaure wrote: > Sounds like the size check should stay then. Pessimizing sendfile for everyone, for the sake of Linux 2.2.x users? REPOSITORY R241 KIO REVISION DETAIL

D28555: File ioslave : use Better setting for sendfile syscall

dfaure added a comment. Sounds like the size check should stay then. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D28555: File ioslave : use Better setting for sendfile syscall

bruns added a comment. @dfaure: probably this: man sendfile, NOTES > The original Linux sendfile() system call was not designed to handle large file offsets. Consequently, Linux 2.4 added sendfile64(), with a wider type for the offset argument. The glibc sendfile() wrapper

D28555: File ioslave : use Better setting for sendfile syscall

meven added a comment. In D28555#641276 , @dfaure wrote: > any idea what buff_src.st_size < 0x7FFF was for? None, it does not makes sense to me, perhaps, we had an implementation limitation. In D28555#641277

D28555: File ioslave : use Better setting for sendfile syscall

broulik added a comment. > reduce the overhead of processedSize dbus progress notification in each iteration since it is called less often, adding some more speed. From what I recall in copy job the processed size in emitted by a timer and not every time a chunk got processed

D28555: File ioslave : use Better setting for sendfile syscall

dfaure added a comment. any idea what buff_src.st_size < 0x7FFF was for? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28555: File ioslave : use Better setting for sendfile syscall

meven added a task: T11627: Improve KIO asynchronicity. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28555: File ioslave : use Better setting for sendfile syscall

meven added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28555 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28555: File ioslave : use Better setting for sendfile syscall

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Changes : - use sendfile when copying file bigger than 2 GB - copy 512 kB