D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

2020-04-25 Thread Stefan Brüns
bruns added a comment. Ping! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28776 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

2020-04-20 Thread Stefan Brüns
bruns added a comment. Ping! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28776 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

2020-04-13 Thread Stefan Brüns
bruns updated this revision to Diff 79989. bruns added a comment. put statics in namespace REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28776?vs=79946=79989 REVISION DETAIL https://phabricator.kde.org/D28776 AFFECTED FILES

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

2020-04-12 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Address the scope of the statics as kai mentioned in D28778 . Or use Q_GLOBAL_STATIC. REPOSITORY R245 Solid REVISION DETAIL

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

2020-04-12 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28776 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

2020-04-12 Thread Stefan Brüns
bruns added a dependent revision: D28777: FstabDevice: Reevaluate emblems only when state changes. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28776 To: bruns, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

2020-04-12 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY emblems can return exactly two different values. Construct the two possible values