D28796: Update Logtalk language syntax support
This revision was automatically updated to reflect the committed changes. Closed by commit R216:bf2664ea7907: Update Logtalk language syntax support (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28796?vs=80017=81172 REVISION DETAIL https://phabricator.kde.org/D28796 AFFECTED FILES data/syntax/logtalk.xml To: pmoura, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
D28796: Update Logtalk language syntax support
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, I see, there is an extra request for the new hl test file. Then let's approve this one. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28796 To: pmoura, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
D28796: Update Logtalk language syntax support
pmoura added a comment. See https://phabricator.kde.org/D28870 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28796 To: pmoura, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
D28796: Update Logtalk language syntax support
pmoura added a comment. There is a more recent version of that file. How to proceed? By creating a new review request for that file with a diff? Or is there a way to associate it with this review request? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28796 To: pmoura, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
D28796: Update Logtalk language syntax support
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Change looks reasonable, but could that testfile be added to our autotests directory? (or the file we have there extended) The current auto test file is autotests/input/highlight.lgt I assume. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28796 To: pmoura, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
D28796: Update Logtalk language syntax support
pmoura created this revision. pmoura added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. pmoura requested review of this revision. REVISION SUMMARY Adds support for new built-predicates and fixes escape sequences in quoted atoms TEST PLAN Tested manually by overriding the file bundled with the latest Kate macOS binary and the syntax highlight source test file from the Logtalk distribution. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28796 AFFECTED FILES data/syntax/logtalk.xml To: pmoura, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
