D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

poboiko added a comment. In D28819#651007 , @dfaure wrote: > The *ideal* way of proceeding is to submit a Qt bug report with your testcase (after searching for an existing Qt bug report for the same issue), then turn it into a Qt autotest and

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

dfaure added a comment. The *ideal* way of proceeding is to submit a Qt bug report with your testcase (after searching for an existing Qt bug report for the same issue), then turn it into a Qt autotest and make a gerrit merge request for Qt with both the test and a fix for it. And then, and

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

poboiko added a comment. @dfaure There seem to be a regression caused by this patch: if I reach the end of current view, and then press Enter so it has to scroll down, it scrolls to the very beginning of the document instead. This is the same issue as in ancient bug 195828

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

This revision was automatically updated to reflect the committed changes. Closed by commit R310:1d1eb6feb7f8: [KRichTextEdit] Always treat key press as single modification in undo stack (authored by poboiko). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH single-undo (branched from master) REVISION DETAIL https://phabricator.kde.org/D28819 To: poboiko, #frameworks, mlaurent, dfaure Cc: ahmadsamir, kde-frameworks-devel,

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

ahmadsamir added a reviewer: dfaure. ahmadsamir added a comment. I tested this with the krichtexteditor test app from kxmlgui, and it works. (It's never too late to fix a bug, even if it's from 2010 :)). REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D28819

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

poboiko edited the summary of this revision. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D28819 To: poboiko, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

poboiko created this revision. poboiko added reviewers: Frameworks, mlaurent. Herald added a project: Frameworks. poboiko requested review of this revision. REVISION SUMMARY If my cursor is on a bullet list, and I press Enter to create a new element, it registers as 5-7 actions in an undo