D28919: Drop delayed second phase

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R297:093a673f0e59: Drop delayed second phase (authored by 
broulik).

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28919?vs=80388=80621

REVISION DETAIL
  https://phabricator.kde.org/D28919

AFFECTED FILES
  src/kded.cpp
  src/kded.h
  src/kdedadaptor.h

To: broulik, #plasma, dfaure, davidedmundson, apol
Cc: apol, kde-frameworks-devel, davidedmundson, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28919: Drop delayed second phase

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I trust your analysis ;)

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D28919

To: broulik, #plasma, dfaure, davidedmundson, apol
Cc: apol, kde-frameworks-devel, davidedmundson, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28919: Drop delayed second phase

[Kai Uwe Broulik]

broulik requested review of this revision.
broulik added a comment.


  Waiting for @dfaure

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D28919

To: broulik, #plasma, dfaure, davidedmundson, apol
Cc: apol, kde-frameworks-devel, davidedmundson, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28919: Drop delayed second phase

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense, sounds like the second phase is quite arbitrary there.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D28919

To: broulik, #plasma, dfaure, davidedmundson, apol
Cc: apol, kde-frameworks-devel, davidedmundson, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28919: Drop delayed second phase

[David Edmundson]

davidedmundson added a comment.


  > @davidedmundson did some bootchart that showed startup is actually faster 
without this
  
  It was probably just noise as it wasn't a full average of N tests, just 2 
clean boots.  However ksplash removed 100ms earlier. I can attach if needed.
  
  As for the patch, +1

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D28919

To: broulik, #plasma, dfaure, davidedmundson
Cc: kde-frameworks-devel, davidedmundson, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28919: Drop delayed second phase

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, dfaure, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  kded runs Phase 0 and Phase 1 on startup and then plasma-session Startup 
calls Phase 2 somewhere around the end of startup.
  Investigation and testing shows this has little effect on startup, if any, 
makes it slower.
  More importantly, it complicates startup and makes it harder to recreate the 
startup sequence as systemd units.

TEST PLAN
  - All services are still started
  - @davidedmundson did some bootchart that showed startup is actually 
//faster// without this
  
  Also refer to my lovely table of services we start: T12616 


REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D28919

AFFECTED FILES
  src/kded.cpp
  src/kded.h
  src/kdedadaptor.h

To: broulik, #plasma, dfaure, davidedmundson
Cc: kde-frameworks-devel, davidedmundson, LeGast00n, cblack, michaelh, ngraham, 
bruns