D29034: Add systemd user service file for kded

2020-05-15 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R297:4ae4de9ff469: Add systemd user service file for kded 
(authored by broulik).

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29034?vs=82868=82949

REVISION DETAIL
  https://phabricator.kde.org/D29034

AFFECTED FILES
  src/CMakeLists.txt
  src/plasma-kded.service.in

To: broulik, #plasma, #frameworks, davidedmundson
Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D29034: Add systemd user service file for kded

2020-05-15 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks, davidedmundson
Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D29034: Add systemd user service file for kded

2020-05-14 Thread Kai Uwe Broulik 
broulik updated this revision to Diff 82868.
broulik added a comment.


  - fix exec
  - add slice

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29034?vs=80722=82868

REVISION DETAIL
  https://phabricator.kde.org/D29034

AFFECTED FILES
  src/CMakeLists.txt
  src/plasma-kded.service.in

To: broulik, #plasma, #frameworks
Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D29034: Add systemd user service file for kded

2020-04-23 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> bruns wrote in plasma-kded.service.in:5
> How about using some LIBEXEC dir instead, this should never be called 
> directly, or am I missing something?

This is unrelated and kded has been there forever

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks
Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D29034: Add systemd user service file for kded

2020-04-23 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> davidedmundson wrote in plasma-kded.service.in:5
> @CMAKE_INSTALL_FULL_BINDIR@

How about using some LIBEXEC dir instead, this should never be called directly, 
or am I missing something?

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks
Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D29034: Add systemd user service file for kded

2020-04-23 Thread David Edmundson 
davidedmundson added a dependent revision: D28305: Systemd Startup.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29034: Add systemd user service file for kded

2020-04-21 Thread Kai Uwe Broulik 
broulik planned changes to this revision.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29034: Add systemd user service file for kded

2020-04-21 Thread David Edmundson 
davidedmundson added a comment.


  We also need to change the installed DBus service file so that we link the 
two in the unlikely event that kded is called
  
  I need to either update the dbus generator macro, or we skip the macro and 
put the service file in here, the old way

INLINE COMMENTS

> broulik wrote in plasma-kded.service.in:5
> Didn't we have a `KDE_INSTALL_BIN_DIR` or something?

@CMAKE_INSTALL_FULL_BINDIR@

> plasma-kded.service.in:6
> +ExecStart=@CMAKE_INSTALL_PREFIX@/bin/kded5
> +BusName=org.kde.kded5

Slice=session.slice

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29034: Add systemd user service file for kded

2020-04-21 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> plasma-kded.service.in:5
> +[Service]
> +ExecStart=@CMAKE_INSTALL_PREFIX@/bin/kded5
> +BusName=org.kde.kded5

Didn't we have a `KDE_INSTALL_BIN_DIR` or something?

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29034: Add systemd user service file for kded

2020-04-21 Thread Kai Uwe Broulik 
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added reviewers: Plasma, Frameworks.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29034: Add systemd user service file for kded

2020-04-21 Thread Kai Uwe Broulik 
broulik created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Merge branch 'master' into broulik/systemd_startup
  
  Rename unit to plasma-kded
  
  Merge branch 'master' into broulik/systemd_startup

REPOSITORY
  R297 KDED

BRANCH
  broulik/systemd_startup

REVISION DETAIL
  https://phabricator.kde.org/D29034

AFFECTED FILES
  src/CMakeLists.txt
  src/plasma-kded.service.in

To: broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns