D29072: Optimize SVG

guoyunhe added a comment. The diff compare is based on Inkscape PNG output. And you can also check git cola's pixel diff, the diff of `icons-dark/actions/22/color-management.svg` looks like this (black means no difference): F8258009: image.png

D29072: Optimize SVG

ndavis added a comment. In D29072#654363 , @guoyunhe wrote: > I do try scour but the result is disappointing. I get 16 times the following error: > > hge difference of 123 in ./icons-dark/apps/48/hwinfo.svg > > > which means 16

D29072: Optimize SVG

guoyunhe added a comment. I do try scour but the result is disappointing. I get 16 times the following error: hge difference of 123 in ./icons-dark/apps/48/hwinfo.svg which means 16 icons are unacceptable after scour optimization REPOSITORY R266 Breeze Icons REVISION

D29072: Optimize SVG

ngraham added a comment. In D29072#654216 , @ndavis wrote: > If we're going to actually use the optimization script, we should use `scour` instead of SVGO. Scour is the SVG optimizer that is least likely to screw up and SVG. These days, the

D29072: Optimize SVG

ndavis added a comment. The Scour settings I recommend are `--set-precision=8 --enable-viewboxing --enable-comment-stripping --remove-descriptive-elements --create-groups --strip-xml-space --strip-xml-prolog --nindent=4` REPOSITORY R266 Breeze Icons REVISION DETAIL

D29072: Optimize SVG

ndavis added a comment. If we're going to actually use the optimization script, we should use `scour` instead of SVGO. Scour is the SVG optimizer that is least likely to screw up and SVG. These days, the purpose of SVG optimization is to make the code readable. REPOSITORY R266 Breeze

D29072: Optimize SVG

ndavis added a comment. > You can check pixel diff in Git Cola. How do I do this? I was not aware of that feature. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29072 To: guoyunhe, #breeze, ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack,

D29072: Optimize SVG

ngraham added reviewers: ndavis, VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29072 To: guoyunhe, #breeze, ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

guoyunhe updated this revision to Diff 80811. guoyunhe added a comment. - Merge some paths REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29072?vs=80810=80811 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29072 AFFECTED FILES

D29072: Optimize SVG

guoyunhe edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29072 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29072 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY Updated optimize-svg.sh script and optimize SVG files. REPOSITORY R266 Breeze Icons BRANCH master REVISION