D29072: Optimize SVG

2020-04-24 Thread Yunhe Guo 
guoyunhe added a comment.


  The diff compare is based on Inkscape PNG output. And you can also check git 
cola's pixel diff, the diff of `icons-dark/actions/22/color-management.svg` 
looks like this (black means no difference):
  
  F8258009: image.png 
  
  The scour solution is D29159 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

2020-04-24 Thread Noah Davis 
ndavis added a comment.


  In D29072#654363 , @guoyunhe wrote:
  
  > I do try scour but the result is disappointing. I get 16 times the 
following error:
  >
  >   hge difference of 123 in ./icons-dark/apps/48/hwinfo.svg
  >
  >
  > which means 16 icons are unacceptable after scour optimization
  
  
  That's not true. Huge difference means you should make sure you know what the 
difference is, but most of the time it's perfectly fine.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

2020-04-22 Thread Yunhe Guo 
guoyunhe added a comment.


  I do try scour but the result is disappointing. I get 16 times the following 
error:
  
hge difference of 123 in ./icons-dark/apps/48/hwinfo.svg
  
  which means 16 icons are unacceptable after scour optimization

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

2020-04-21 Thread Nathaniel Graham 
ngraham added a comment.


  In D29072#654216 , @ndavis wrote:
  
  > If we're going to actually use the optimization script, we should use 
`scour` instead of SVGO. Scour is the SVG optimizer that is least likely to 
screw up and SVG. These days, the purpose of SVG optimization is to make the 
code readable.
  
  
  Perhaps the script should be updated to do that?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

2020-04-21 Thread Noah Davis 
ndavis added a comment.


  The Scour settings I recommend are `--set-precision=8 --enable-viewboxing 
--enable-comment-stripping --remove-descriptive-elements --create-groups 
--strip-xml-space --strip-xml-prolog --nindent=4`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

2020-04-21 Thread Noah Davis 
ndavis added a comment.


  If we're going to actually use the optimization script, we should use `scour` 
instead of SVGO. Scour is the SVG optimizer that is least likely to screw up 
and SVG. These days, the purpose of SVG optimization is to make the code 
readable.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

2020-04-21 Thread Noah Davis 
ndavis added a comment.


  > You can check pixel diff in Git Cola.
  
  How do I do this? I was not aware of that feature.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

2020-04-21 Thread Nathaniel Graham 
ngraham added reviewers: ndavis, VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

2020-04-21 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 80811.
guoyunhe added a comment.


  - Merge some paths

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29072?vs=80810=80811

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29072

AFFECTED FILES
  icons-dark/actions/22/color-management.svg
  icons-dark/actions/22/im-skype.svg
  icons-dark/actions/22/office-chart-polar.svg
  icons-dark/actions/22/run-build-clean.svg
  icons-dark/actions/22/run-build-configure.svg
  icons-dark/actions/22/run-build-file.svg
  icons-dark/actions/22/run-build-prune.svg
  icons-dark/actions/22/run-build.svg
  icons-dark/actions/22/step_object_CircularMotor.svg
  icons-dark/actions/22/step_object_LinearMotor.svg
  icons-dark/actions/22/step_object_SoftBody.svg
  icons-dark/actions/32/colors-luma.svg
  icons-dark/actions/symbolic/pan-down-symbolic.svg
  icons-dark/actions/symbolic/pan-end-symbolic.svg
  icons-dark/actions/symbolic/pan-start-symbolic.svg
  icons-dark/actions/symbolic/pan-up-symbolic.svg
  icons-dark/actions/symbolic/selection-end-symbolic.svg
  icons-dark/actions/symbolic/selection-start-symbolic.svg
  icons-dark/applets/128/user-none.svg
  icons-dark/applets/48/weather-clouds-night.svg
  icons-dark/applets/48/weather-few-clouds-night.svg
  icons-dark/applets/48/weather-showers-day.svg
  icons-dark/applets/48/weather-showers-scattered-night.svg
  icons-dark/applets/48/weather-snow-rain.svg
  icons-dark/applets/48/weather-snow-scattered-day.svg
  icons-dark/applets/48/weather-snow.svg
  icons-dark/apps/48/QtProject-designer.svg
  icons-dark/apps/48/accessories-calculator.svg
  icons-dark/apps/48/accessories-character-map.svg
  icons-dark/apps/48/acroread.svg
  icons-dark/apps/48/alienarena.svg
  icons-dark/apps/48/anjuta.svg
  icons-dark/apps/48/babe.svg
  icons-dark/apps/48/baloo.svg
  icons-dark/apps/48/bluegriffon.svg
  icons-dark/apps/48/bovo.svg
  icons-dark/apps/48/braindump.svg
  icons-dark/apps/48/choqok.svg
  icons-dark/apps/48/codeblocks.svg
  icons-dark/apps/48/diaspora.svg
  icons-dark/apps/48/digikam.svg
  icons-dark/apps/48/falkon.svg
  icons-dark/apps/48/granatier.svg
  icons-dark/apps/48/hwinfo.svg
  icons-dark/apps/48/kapman.svg
  icons-dark/apps/48/karbon.svg
  icons-dark/apps/48/kbruch.svg
  icons-dark/apps/48/kde-im-log-viewer.svg
  icons-dark/apps/48/kdiff3.svg
  icons-dark/apps/48/kmag.svg
  icons-dark/apps/48/knights.svg
  icons-dark/apps/48/ksnapshot.svg
  icons-dark/apps/48/ktorrent.svg
  icons-dark/apps/48/logisim.svg
  icons-dark/apps/48/lokalize.svg
  icons-dark/apps/48/mpv.svg
  icons-dark/apps/48/muondiscover.svg
  icons-dark/apps/48/octave.svg
  icons-dark/apps/48/phonon-gstreamer.svg
  icons-dark/apps/48/planetkde.svg
  icons-dark/apps/48/plasma-media-center.svg
  icons-dark/apps/48/qdbusviewer.svg
  icons-dark/apps/48/qtcreator.svg
  icons-dark/apps/48/showfoto.svg
  icons-dark/apps/48/skanlite.svg
  icons-dark/apps/48/step.svg
  icons-dark/apps/48/umbrello.svg
  icons-dark/apps/48/utilities-log-viewer.svg
  icons-dark/apps/48/words.svg
  icons-dark/apps/48/xorg.svg
  icons-dark/categories/32/applications-office.svg
  icons-dark/devices/64/camera-video.svg
  icons-dark/devices/64/input-gaming.svg
  icons-dark/devices/64/media-flash-memory-stick.svg
  icons-dark/devices/64/media-optical-blu-ray.svg
  icons-dark/devices/64/network-rj11-female.svg
  icons-dark/devices/64/network-rj45-female.svg
  icons-dark/mimetypes/16/application-pgp-signature.svg
  icons-dark/mimetypes/16/text-dockerfile.svg
  icons-dark/mimetypes/22/android-package-archive.svg
  icons-dark/mimetypes/22/application-certificate.svg
  icons-dark/mimetypes/22/application-illustrator.svg
  icons-dark/mimetypes/22/application-msonenote.svg
  icons-dark/mimetypes/22/application-msoutlook.svg
  icons-dark/mimetypes/22/application-msword.svg
  icons-dark/mimetypes/22/application-vnd.ms-excel.addin.macroenabled.12.svg
  icons-dark/mimetypes/22/application-vnd.ms-infopath.svg
  icons-dark/mimetypes/22/application-vnd.oasis.opendocument.text-template.svg
  icons-dark/mimetypes/22/application-x-apple-diskimage.svg
  icons-dark/mimetypes/22/application-x-bzip.svg
  icons-dark/mimetypes/22/application-x-font-ttf.svg
  icons-dark/mimetypes/22/application-x-gettext-translation.svg
  icons-dark/mimetypes/22/application-x-javascript.svg
  icons-dark/mimetypes/22/application-x-lyx.svg
  icons-dark/mimetypes/22/application-x-perl.svg
  icons-dark/mimetypes/22/application-x-rdata.svg
  icons-dark/mimetypes/22/application-x-trash.svg
  icons-dark/mimetypes/22/application-x-xliff.svg
  icons-dark/mimetypes/22/application-xmind.svg
  icons-dark/mimetypes/22/application-zip.svg
  icons-dark/mimetypes/22/image-bmp.svg
  icons-dark/mimetypes/22/image-jpeg.svg
  icons-dark/mimetypes/22/image-tiff.svg
  icons-dark/mimetypes/22/image-x-generic.svg
  icons-dark/mimetypes/22/image-x-psd.svg
  icons-dark/mimetypes/22/image-x-tga.svg
  icons-dark/mimetypes/22/image-x-xcf.svg

D29072: Optimize SVG

2020-04-21 Thread Yunhe Guo 
guoyunhe edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

2020-04-21 Thread Yunhe Guo 
guoyunhe added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

2020-04-21 Thread Yunhe Guo 
guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Updated optimize-svg.sh script and optimize SVG files.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29072

AFFECTED FILES
  icons-dark/actions/22/color-management.svg
  icons-dark/actions/22/im-skype.svg
  icons-dark/actions/22/office-chart-polar.svg
  icons-dark/actions/22/run-build-clean.svg
  icons-dark/actions/22/run-build-configure.svg
  icons-dark/actions/22/run-build-file.svg
  icons-dark/actions/22/run-build-prune.svg
  icons-dark/actions/22/run-build.svg
  icons-dark/actions/22/step_object_CircularMotor.svg
  icons-dark/actions/22/step_object_LinearMotor.svg
  icons-dark/actions/22/step_object_SoftBody.svg
  icons-dark/actions/32/colors-luma.svg
  icons-dark/actions/symbolic/pan-down-symbolic.svg
  icons-dark/actions/symbolic/pan-end-symbolic.svg
  icons-dark/actions/symbolic/pan-start-symbolic.svg
  icons-dark/actions/symbolic/pan-up-symbolic.svg
  icons-dark/actions/symbolic/selection-end-symbolic.svg
  icons-dark/actions/symbolic/selection-start-symbolic.svg
  icons-dark/applets/128/user-none.svg
  icons-dark/applets/48/weather-clouds-night.svg
  icons-dark/applets/48/weather-few-clouds-night.svg
  icons-dark/applets/48/weather-showers-day.svg
  icons-dark/applets/48/weather-showers-scattered-night.svg
  icons-dark/applets/48/weather-snow-rain.svg
  icons-dark/applets/48/weather-snow-scattered-day.svg
  icons-dark/applets/48/weather-snow.svg
  icons-dark/apps/48/QtProject-designer.svg
  icons-dark/apps/48/accessories-calculator.svg
  icons-dark/apps/48/accessories-character-map.svg
  icons-dark/apps/48/acroread.svg
  icons-dark/apps/48/alienarena.svg
  icons-dark/apps/48/anjuta.svg
  icons-dark/apps/48/babe.svg
  icons-dark/apps/48/baloo.svg
  icons-dark/apps/48/bluegriffon.svg
  icons-dark/apps/48/bovo.svg
  icons-dark/apps/48/braindump.svg
  icons-dark/apps/48/choqok.svg
  icons-dark/apps/48/codeblocks.svg
  icons-dark/apps/48/diaspora.svg
  icons-dark/apps/48/digikam.svg
  icons-dark/apps/48/falkon.svg
  icons-dark/apps/48/granatier.svg
  icons-dark/apps/48/hwinfo.svg
  icons-dark/apps/48/kapman.svg
  icons-dark/apps/48/karbon.svg
  icons-dark/apps/48/kbruch.svg
  icons-dark/apps/48/kde-im-log-viewer.svg
  icons-dark/apps/48/kdiff3.svg
  icons-dark/apps/48/kmag.svg
  icons-dark/apps/48/knights.svg
  icons-dark/apps/48/ksnapshot.svg
  icons-dark/apps/48/ktorrent.svg
  icons-dark/apps/48/logisim.svg
  icons-dark/apps/48/lokalize.svg
  icons-dark/apps/48/mpv.svg
  icons-dark/apps/48/muondiscover.svg
  icons-dark/apps/48/octave.svg
  icons-dark/apps/48/phonon-gstreamer.svg
  icons-dark/apps/48/planetkde.svg
  icons-dark/apps/48/plasma-media-center.svg
  icons-dark/apps/48/qdbusviewer.svg
  icons-dark/apps/48/qtcreator.svg
  icons-dark/apps/48/showfoto.svg
  icons-dark/apps/48/skanlite.svg
  icons-dark/apps/48/step.svg
  icons-dark/apps/48/umbrello.svg
  icons-dark/apps/48/utilities-log-viewer.svg
  icons-dark/apps/48/words.svg
  icons-dark/apps/48/xorg.svg
  icons-dark/categories/32/applications-office.svg
  icons-dark/devices/64/camera-video.svg
  icons-dark/devices/64/input-gaming.svg
  icons-dark/devices/64/media-flash-memory-stick.svg
  icons-dark/devices/64/media-optical-blu-ray.svg
  icons-dark/devices/64/network-rj11-female.svg
  icons-dark/devices/64/network-rj45-female.svg
  icons-dark/mimetypes/16/application-pgp-signature.svg
  icons-dark/mimetypes/16/text-dockerfile.svg
  icons-dark/mimetypes/22/android-package-archive.svg
  icons-dark/mimetypes/22/application-certificate.svg
  icons-dark/mimetypes/22/application-illustrator.svg
  icons-dark/mimetypes/22/application-msonenote.svg
  icons-dark/mimetypes/22/application-msoutlook.svg
  icons-dark/mimetypes/22/application-msword.svg
  icons-dark/mimetypes/22/application-vnd.ms-excel.addin.macroenabled.12.svg
  icons-dark/mimetypes/22/application-vnd.ms-infopath.svg
  icons-dark/mimetypes/22/application-vnd.oasis.opendocument.text-template.svg
  icons-dark/mimetypes/22/application-x-apple-diskimage.svg
  icons-dark/mimetypes/22/application-x-bzip.svg
  icons-dark/mimetypes/22/application-x-font-ttf.svg
  icons-dark/mimetypes/22/application-x-gettext-translation.svg
  icons-dark/mimetypes/22/application-x-javascript.svg
  icons-dark/mimetypes/22/application-x-lyx.svg
  icons-dark/mimetypes/22/application-x-perl.svg
  icons-dark/mimetypes/22/application-x-rdata.svg
  icons-dark/mimetypes/22/application-x-trash.svg
  icons-dark/mimetypes/22/application-x-xliff.svg
  icons-dark/mimetypes/22/application-xmind.svg
  icons-dark/mimetypes/22/application-zip.svg
  icons-dark/mimetypes/22/image-bmp.svg
  icons-dark/mimetypes/22/image-jpeg.svg
  icons-dark/mimetypes/22/image-tiff.svg
  icons-dark/mimetypes/22/image-x-generic.svg
  icons-dark/mimetypes/22/image-x-psd.svg
  icons-dark/mimetypes/22/image-x-tga.svg