D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-25 Thread Noah Davis
ndavis commandeered this revision. ndavis added a reviewer: saligari. ndavis added a comment. Saligari is Ok with me taking over this patch. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis, ngraham,

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-25 Thread Noah Davis
ndavis added a comment. In D29095#656819 , @saligari wrote: > Oh the shame! I had forgotten to center it (and I do know how to)! > > One thing I don't know is: since I centered it and used the guidelines my 1px line centered sits on a 0,5 to

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-25 Thread Chris Escargot
saligari updated this revision to Diff 81156. saligari added a comment. Oh the shame! I had forgotten to center it (and I do know how to)! One thing I don't know is: since I centered it and used the guidelines my 1px line centered sits on a 0,5 to 0,5 line. I don't know if that's bad or

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-24 Thread Noah Davis
ndavis added a comment. It's a bit off center and I'd prefer if lines were more aligned with pixels. That way the icon doesn't change in how it looks when you scale it up. You may need to lighten the colors of your lines to maintain the original appearance. You see what I'm seeing? Do

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-24 Thread Chris Escargot
saligari updated this revision to Diff 81138. saligari added a comment. My search on the internet told me LGTM stands for looks good to me. I added a 32px with 3px margin REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=81126=81138 BRANCH

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-24 Thread Nathaniel Graham
ngraham added a comment. LGTM now! While you're at it, could you create a 32px version and replace `icons/preferences/32/preferences-desktop-mouse.svg`? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: saligari, #vdg Cc: bruns, ouwerkerk, ndavis,

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-24 Thread Chris Escargot
saligari updated this revision to Diff 81126. saligari added a comment. - a bit darker, with a more pronounced gradient effect REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=81041=81126 BRANCH input-mouse-patch (branched from master)

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-23 Thread Nathaniel Graham
ngraham added a comment. That's much better! I think I'd use a slightly darker shade of gray though. Not much, just a bit. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: saligari, #vdg Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel,

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-23 Thread Chris Escargot
saligari updated this revision to Diff 81041. saligari added a comment. - corrected hard edges - aaand that's it probably for me, I'm reasonably happy with this and I think I've learned quite a bit - Here it is ^_^ REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-23 Thread Stefan Brüns
bruns added a comment. > Bruns's comment about right-handed mice (gradient) is due to the quite asymmetrical shape many modern mice use for ergonomic reasons (RSI). No, even for a ball bottom right is darkest. Shapes should be drawn as if there were a light at the top left, i.e. with a

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-23 Thread Chris Escargot
saligari updated this revision to Diff 81032. saligari added a comment. - tried to change the shape into something more modern (though I quite like the old-ish look) - changed the gradient as bruns said, can't say I see much difference - removed the middle curve REPOSITORY R266 Breeze

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-23 Thread Johan Ouwerkerk
ouwerkerk added a comment. In D29095#655214 , @ngraham wrote: > FWIW all the mice in my house have this exact shape, but they're black, not gray. So I don't think the shape is too old-fashioned per se. It's the gray color that's anacrhonistic

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-23 Thread Stefan Brüns
bruns added a comment. F8255905: bitmap.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: saligari, #vdg Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-23 Thread Stefan Brüns
bruns added a comment. The new one looks very oldschool. Some ideas how to improve that: - buttons are typically only separated from each other, but not from the body, try removing the horizontal line - the body should be narrower at the center - the gradient does not match the

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-23 Thread Nathaniel Graham
ngraham added a comment. Hmm yeah, that gray color is probably too dark. Also a color that dark likely wouldn't need an outline as it would be visible on both light and dark backgrounds. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: saligari, #vdg

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-23 Thread Chris Escargot
saligari updated this revision to Diff 80971. saligari added a comment. Changed the icon, with ndavis' help, so that it better fits its 64px place. I also tried joystick's/input gaming colors but didn't like it much, here's a comparison in 64px: REPOSITORY R266 Breeze Icons CHANGES

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Nathaniel Graham
ngraham added a comment. FWIW all the mice in my house have this exact shape, but they're black, not gray. So I don't think the shape is too old-fashioned per se. It's the gray color that's anacrhonistic part, since it's a very 90s/early 2000s color and modern mice tend to be black:

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment. > If on the other hand you really like the old mouse icon as well but just want it to work better for dark themes then another option might be to recolour the old icon to get better contrast out of it against the dark background. I tried modifying the

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Johan Ouwerkerk
ouwerkerk added a comment. In D29095#655060 , @saligari wrote: > > Maybe this is just me but the overall width to height ratio makes it seem that the closest "real" mice are quite dated as well. > > I don't understand what you mean with

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari updated this revision to Diff 80935. saligari added a comment. Added a better border, it does look better like this. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=80928=80935 BRANCH input-mouse-patch (branched from master)

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment. > Maybe this is just me but the overall width to height ratio makes it seem that the closest "real" mice are quite dated as well. I don't understand what you mean with this, do you think it should be slimmer? I kind of followed the old one in this, even if it

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Noah Davis
ndavis added a comment. Yes, I agree that the mouse should have fairly realistic and modern proportions. My favorite icons in Breeze are the ones that look pretty realistic while still maintaining the soft gradients and shadows. REPOSITORY R266 Breeze Icons REVISION DETAIL

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Johan Ouwerkerk
ouwerkerk added a comment. One thing I find really striking about the new icon is how closely it resembles stress balls: F8253927: stress-ball-mice.png I kinda like that... :) REPOSITORY R266 Breeze Icons REVISION DETAIL

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Johan Ouwerkerk
ouwerkerk added a comment. Hmm, the old icon also has the virtue of looking more like genuine computer mice: it resembles the logi(tech) style of mouse design quite well. This one is rather abstract while at the same time somehow not looking like any "real" mouse would, in particular in its

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari updated this revision to Diff 80928. saligari added a comment. - Fixed margins - added *some* perspective, I hope it looks better. I don't know if maybe I should add curvature - used inkscape to optimize it - I really have no idea on how to make it less boring REPOSITORY

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment. In D29095#655030 , @ngraham wrote: > Awesome, that's much nicer. > > I think it needs the outline.border to extend up to the top, or else the top of the icon starts to blend in with the default window color:

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Nathaniel Graham
ngraham added a comment. Awesome, that's much nicer. I think it needs the outline.border to extend up to the top, or else the top of the icon starts to blend in with the default window color: F8253868: Screenshot_20200422_124714.png REPOSITORY

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment. In D29095#654825 , @ndavis wrote: > Regarding SVG optimization, the main point of it these days is to make the code easier to read, not to get the smallest size possible. Use the settings on this page for your SVG

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Noah Davis
ndavis added a comment. Regarding SVG optimization, the main point of it these days is to make the code easier to read, not to get the smallest size possible. Use the settings on this page for your SVG optimizer: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips REPOSITORY

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Nathaniel Graham
ngraham added a comment. Things I like: - It's lighter and will show up in both light and dark themes - It isn't trying to look like a cool gaming mouse, which always seemed a bit childish to me Things I don't like: - The horizontal line in the center needs some perspective

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari updated this revision to Diff 80889. saligari added a comment. Used svgcleaner to change the icon from 7.3KiB to 1.6KiB REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=80882=80889 BRANCH input-mouse-patch (branched from master)

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari added a comment. Running svgcleaner on this icon turns it from a 7.3 KiB monstrosity to 1.6 KiB beauty. However I don't know how to update this patch :(. The existing icon is something like 7.9KiB but this one is doesn't have that much detail, it shouldn't be such a big file.

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari edited the test plan for this revision. saligari added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: saligari, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

2020-04-22 Thread Chris Escargot
saligari created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. saligari requested review of this revision. REVISION SUMMARY A very very simple mouse icon, which hopefully adheres to the general HIG. Most colors are borrowed from the