D29189: [KInotify] Fix path matching when removing watches

2020-04-26 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:73183acf00a2: [KInotify] Fix path matching when removing 
watches (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29189?vs=81204=81242#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29189?vs=81204=81242

REVISION DETAIL
  https://phabricator.kde.org/D29189

AFFECTED FILES
  autotests/unit/file/filewatchtest.cpp
  autotests/unit/file/kinotifytest.cpp
  src/file/kinotify.cpp

To: bruns, #baloo, ngraham, meven
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D29189: [KInotify] Fix path matching when removing watches

2020-04-26 Thread Méven Car
meven accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  fwtest

REVISION DETAIL
  https://phabricator.kde.org/D29189

To: bruns, #baloo, ngraham, meven
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D29189: [KInotify] Fix path matching when removing watches

2020-04-26 Thread Stefan Brüns
bruns edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D29189

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D29189: [KInotify] Fix path matching when removing watches

2020-04-26 Thread Stefan Brüns
bruns added a dependent revision: D29191: [FileWatch] Fix watch updates on 
config changes.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D29189

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D29189: [KInotify] Fix path matching when removing watches

2020-04-25 Thread Stefan Brüns
bruns edited the summary of this revision.
bruns added a dependency: D29190: [FileWatchTest] Extend coverage to config 
updates.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D29189

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D29189: [KInotify] Fix path matching when removing watches

2020-04-25 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  As in removeWatch the path is passed in with a trailing slash, no path
  is removed.

TEST PLAN
  ctest -R filewatch

REPOSITORY
  R293 Baloo

BRANCH
  fwtest

REVISION DETAIL
  https://phabricator.kde.org/D29189

AFFECTED FILES
  autotests/unit/file/filewatchtest.cpp
  src/file/kinotify.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams