D29479: Fix rounded borders

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1bc004e5c65f: Fix rounded borders (authored by niccolove). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29479?vs=82133=82147#toc REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE

D29479: Fix rounded borders

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma, broulik Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack,

D29479: Fix rounded borders

niccolove marked 2 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma, broulik Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29479: Fix rounded borders

niccolove added inline comments. INLINE COMMENTS > broulik wrote in PlasmoidHeading.qml:74 > Where is `plasmoid` defined? It's not necessary to define it, when you use this in a plasmoid it takes it from the context REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D29479: Fix rounded borders

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma, broulik Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29479: Fix rounded borders

niccolove updated this revision to Diff 82133. niccolove added a comment. Round things up again REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29479?vs=82131=82133 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29479

D29479: Fix rounded borders

niccolove marked 2 inline comments as done. niccolove added a comment. In D29479#664767 , @broulik wrote: > Notifications don't use `PlasmoidHeading` Heh, it was actually an unrelated mistake: D29490

D29479: Fix rounded borders

niccolove updated this revision to Diff 82131. niccolove added a comment. Address some feedback REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29479?vs=82078=82131 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29479

D29479: Fix rounded borders

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Notifications don't use `PlasmoidHeading` INLINE COMMENTS > PlasmoidHeading.qml:71 > +enabledBorders: { > +var borders = new Array() > +borders

D29479: Fix rounded borders

ngraham added a comment. This fixes the square corners on tray popups for me, but not notifications. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29479: Fix rounded borders

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29479: Fix rounded borders

niccolove edited the test plan for this revision. niccolove added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29479: Fix rounded borders

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY This makes borders of elements using plasmoidHeading rounded again REPOSITORY R242 Plasma Framework (Library)