D5001: Add support for killing a KAuth::ExecuteJob

2017-03-13 Thread Dan Leinir Turthra Jensen 
leinir closed this revision.
leinir added a comment.


  Closed by commit 
https://commits.kde.org/kauth/39621f485f434fb4453a1fd6af2796cde23eec53

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D5001

To: leinir, #frameworks, jriddell
Cc: jriddell

D5001: Add support for killing a KAuth::ExecuteJob

2017-03-10 Thread Jonathan Riddell 
jriddell accepted this revision.
jriddell added a comment.
This revision is now accepted and ready to land.


  yep works well in my example

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D5001

To: leinir, #frameworks, jriddell
Cc: jriddell

D5001: Add support for killing a KAuth::ExecuteJob

2017-03-10 Thread Dan Leinir Turthra Jensen 
leinir created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This implements the standard method for stopping a KJob in KAuth::ExecuteJob. 
It is done using a minimal-intrusion approach, and is supposed to feel familiar 
to people already used to working with KJobs.

TEST PLAN
  Tested using an existing kcm which assumed the existence of this slot in 
ExecuteJob, and the job stops as expected, and returns the appropriate signals.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D5001

AFFECTED FILES
  src/kauthexecutejob.cpp
  src/kauthexecutejob.h
  src/kauthhelpersupport.h

To: leinir, #frameworks